-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding some loc locked tags #28553
Adding some loc locked tags #28553
Conversation
…e as an example going forward
Approved under the assumption that lock terminology is correct. Would it also be easier to tell localization efforts to not translate anything wrapped in `? |
@@ -273,7 +273,7 @@ | |||
</data> | |||
<data name="ProjectCapabilityConstraint_Restricted_NotRestored_CTA" xml:space="preserve"> | |||
<value>Run 'dotnet restore {0}' to restore the project.</value> | |||
<comment>do not translate 'dotnet restore {0}'</comment> | |||
<comment>{Locked="dotnet restore {0}"}</comment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With new syntax, would it be automatic processing or still manual?
Otherwise not sure if it's worth replacing old text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the prior text should not have been used here and it was relying on the translator noticing the text whereas I think the Locked text actually affects the tooling on the loc side.
@cristianosuzuki77 any opinion on fixing old comments with the Locked format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have been using the comments like this for quite a time, and it helped to avoid translation issues, so it seems the translators see them easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I just don't know if the Locked format automatically removes them from the tooling so the exclusion is more automated than manual.
…x for any that are off.
…T-addlocignoreexample
Add loc locked to two of the strings to help the translators and serve as an example going forward