Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0.2xx] Backport Add Blazor SWA Baseline Mismatched Assets Logging #28883

Closed

Conversation

TanayParikh
Copy link
Contributor

Backports #27542

* Add Blazor AssetDifferencesDetails

* Update AspNetSdkBaselineTest.cs

For https://github.com/dotnet/sdk/issues/27346

* Spacing

* Create blazor-swa-baseline-generation.md

* PR Feedback

* Remove instructions add script reference

* Property level comparison

* Added instructions

* Update AspNetSdkBaselineTest.cs

* Update AspNetSdkBaselineTest.cs

(cherry picked from commit bacc17c)
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@TanayParikh
Copy link
Contributor Author

TanayParikh commented Nov 3, 2022

@marcpopMSFT @dsplaisted where else do you believe we should backport this? Or maybe we handle it on a case-by-case basis?

@TanayParikh TanayParikh added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Nov 3, 2022
@TanayParikh TanayParikh self-assigned this Nov 3, 2022
@build-analysis build-analysis bot mentioned this pull request Nov 3, 2022
2 tasks
@marcpopMSFT
Copy link
Member

Will this make the tests more stable? 7.0.1xx will be in support for ~18 months so anything that helps make codeflow PRs more reliable is worth taking. I've ported dozens of improvements to 6.0.1xx for test stability for similar reasons.

@TanayParikh
Copy link
Contributor Author

TanayParikh commented Nov 3, 2022

Will this make the tests more stable?

This will have no impact on stability. The purpose of this change is to provide clarity on why the baseline tests failed (asset added/removed, or specific property changed), as well as steps to update the baselines should the change in fact be expected. Examples of what the error messages will now look like.

Note, the test failures / instability caused by the baselines, aren't necessarily Blazor specific issues. The baselines act as a catch-all for issues across the stack. For instance, just the other day, the baselines caught #28796 (comment).

7.0.1xx will be in support for ~18 months
6.0.1xx

Will backport there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants