This call is failing on the Darwin leg in installer. #29916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it and see if the test can pass as I don't think that check is necessary anymore. We can potentially just remove the 1.1 and 2.0 targeting if this is blocking.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
nagilson
approved these changes
Jan 12, 2023
marcpopMSFT
pushed a commit
that referenced
this pull request
Jan 13, 2023
marcpopMSFT
pushed a commit
that referenced
this pull request
Jan 13, 2023
marcpopMSFT
pushed a commit
that referenced
this pull request
Jan 13, 2023
nagilson
added a commit
that referenced
this pull request
Jan 14, 2023
nagilson
added a commit
that referenced
this pull request
Jan 16, 2023
ViktorHofer
pushed a commit
that referenced
this pull request
Jan 17, 2023
marcpopMSFT
pushed a commit
that referenced
this pull request
Jan 20, 2023
dsplaisted
added a commit
that referenced
this pull request
Jan 31, 2023
marcpopMSFT
pushed a commit
that referenced
this pull request
Jan 31, 2023
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Jan 31, 2023
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Jan 31, 2023
marcpopMSFT
pushed a commit
that referenced
this pull request
Feb 7, 2023
marcpopMSFT
added a commit
that referenced
this pull request
Feb 13, 2023
marcpopMSFT
added a commit
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's just remove it and see if the test can pass as I don't think that check is necessary anymore.
We can potentially just remove the 1.1 and 2.0 targeting if this is blocking.
dotnet/installer#15265 (comment)