Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the test that verifies generated join symbol with Ref to derived symbol can be evaluated correctly #31564

Closed
wants to merge 1 commit into from

Conversation

GangWang01
Copy link
Member

Problem

dotnet/templating#6291 - lacks test for generated symbol with ref to computed symbol.

Solution

Add the test.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 31, 2023
@GangWang01 GangWang01 marked this pull request as ready for review March 31, 2023 10:33
@GangWang01 GangWang01 requested a review from a team as a code owner March 31, 2023 10:33
@vlada-shubina
Copy link
Member

Please move this test to dotnet/templating as it is testing authoring feature. example: https://github.com/dotnet/templating/blob/main/test/Microsoft.TemplateEngine.IDE.IntegrationTests/SnapshotTests.cs

@GangWang01
Copy link
Member Author

GangWang01 commented Apr 4, 2023

Please move this test to dotnet/templating as it is testing authoring feature. example: https://github.com/dotnet/templating/blob/main/test/Microsoft.TemplateEngine.IDE.IntegrationTests/SnapshotTests.cs

@vlada-shubina when I moved the test to dotnet/templating using verification engine as you suggested, I found a problem. dotnet used by the verification engine in dotnet/templating is specified in https://github.com/dotnet/templating/blob/b1a9547fd5633e59fec7eb609b644c0b387cdf02/global.json#L3 which doesn't have the latest change to dotnet/templating. It's not able to catch issues in time through the test. I think the test should be placed in SDK. How do you think?

@vlada-shubina
Copy link
Member

vlada-shubina commented Apr 4, 2023

Please move this test to dotnet/templating as it is testing authoring feature. example: https://github.com/dotnet/templating/blob/main/test/Microsoft.TemplateEngine.IDE.IntegrationTests/SnapshotTests.cs

@vlada-shubina when I moved the test to dotnet/templating using verification engine as you suggested, I found a problem. dotnet used by the verification engine in dotnet/templating is specified in https://github.com/dotnet/templating/blob/b1a9547fd5633e59fec7eb609b644c0b387cdf02/global.json#L3 which doesn't have the latest change to dotnet/templating. It's not able to catch issues in time through the test. I think the test should be placed in SDK. How do you think?

We should use API when launching verify tests in templating. Please see example in https://github.com/dotnet/templating/blob/b1a9547fd5633e59fec7eb609b644c0b387cdf02/test/Microsoft.TemplateEngine.IDE.IntegrationTests/SnapshotTests.cs#L39

@GangWang01
Copy link
Member Author

I see. Thanks for the explanation!

@GangWang01 GangWang01 closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants