Use host model for apphost #3447
Conversation
wli3
force-pushed
the
use-HostModel-for-apphost
branch
2 times, most recently
from
0df1c22 to
c865134
Compare
|
@nguerrera do you mind to review this PR now. I am still waiting for core-setup bit flow to make tests pass. But I hope to get that in before monday so I won't need to be in ask mode |
|
Looks good, now that CLI has host model, you will need to get it through core-sdk and back to stage 0, unfortunately, I think. Otherwise you will get the one from CLi loaded, I think. :( This is another data point to put together my repo consolidation proposal.... You can add ExcludeAssets=runtime for .net core to HostModel package reference now I think, like dependency model. This will save us an unnecesarry copy of the dll in the full SDK. |
wli3
force-pushed
the
use-HostModel-for-apphost
branch
3 times, most recently
from
fcd794f to
1168706
Compare
Use extracted Microsoft.NET.HostModel.AppHost
Co-Authored-By: Nick Guerrera <nicholg@microsoft.com>
wli3
force-pushed
the
use-HostModel-for-apphost
branch
from
93708ac to
b6e12c7
Compare
|
@nguerrera tests should all pass now. It is good to review. I will squash merge it From last time you review.
|
| @@ -113,20 +113,20 @@ protected override void ExecuteCore() | |||
|
|
|||
| try | |||
| { | |||
| var windowsGraphicalUserInterface = runtimeIdentifier.StartsWith("win") && "WinExe".Equals(OutputType, StringComparison.OrdinalIgnoreCase); | |||
There was a problem hiding this comment.
I added this change since last review.
sorry for the churn. The feedback loop of tests is slow.
I realize I do need to recalculate WindowsGraphicalUserInterface, since WindowsGraphicalUserInterface depends on UseApphost which will always be false in dotnet tools.
…0191103.2 (dotnet#3447) - Microsoft.NETCore.App.Ref - 3.1.0-preview3.19553.2 - Microsoft.NETCore.App.Runtime.win-x64 - 3.1.0-preview3.19553.2 Dependency coherency updates - Microsoft.NET.Sdk.WindowsDesktop - 3.1.0-preview2.19553.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - System.CodeDom - 4.7.0-preview3.19551.4 (parent: Microsoft.NETCore.App.Runtime.win-x64) - System.Security.Cryptography.ProtectedData - 4.7.0-preview3.19551.4 (parent: Microsoft.NETCore.App.Runtime.win-x64) - System.Text.Encoding.CodePages - 4.7.0-preview3.19551.4 (parent: Microsoft.NETCore.App.Runtime.win-x64) - System.Resources.Extensions - 4.7.0-preview3.19551.4 (parent: Microsoft.NETCore.App.Runtime.win-x64)
part of #11300