Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/windowsdesktop #36125

Merged
merged 11 commits into from
Oct 20, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 14, 2023

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Sdk.WindowsDesktop: from 9.0.0-alpha.1.23512.1 to 9.0.0-alpha.1.23519.4 (parent: Microsoft.WindowsDesktop.App.Ref)

From https://github.com/dotnet/windowsdesktop

  • Subscription: 43b77b68-0b3c-49dd-3915-08d8e9750bf8
  • Build: 20231019.18
  • Date Produced: October 20, 2023 3:10:30 AM UTC
  • Commit: 557ec081e6ca0fb7f8deb21f87582242c5f08af8
  • Branch: refs/heads/main

…ld 20231013.10

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-alpha.1.23513.1 -> To Version 9.0.0-alpha.1.23513.10

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop
 From Version 9.0.0-alpha.1.23512.1 -> To Version 9.0.0-alpha.1.23513.1 (parent: Microsoft.WindowsDesktop.App.Ref
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Oct 14, 2023
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

3 similar comments
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

dotnet-maestro bot and others added 2 commits October 17, 2023 02:56
…ld 20231016.6

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-alpha.1.23513.1 -> To Version 9.0.0-alpha.1.23516.6

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop
 From Version 9.0.0-alpha.1.23512.1 -> To Version 9.0.0-alpha.1.23516.2 (parent: Microsoft.WindowsDesktop.App.Ref
@v-wuzhai
Copy link
Member

@dotnet/dotnet-windowsdesktop-admin Could you take a look at the failures here?

…ld 20231017.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-alpha.1.23513.1 -> To Version 9.0.0-alpha.1.23517.1

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop
 From Version 9.0.0-alpha.1.23512.1 -> To Version 9.0.0-alpha.1.23516.17 (parent: Microsoft.WindowsDesktop.App.Ref
…ld 20231017.2

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-alpha.1.23513.1 -> To Version 9.0.0-alpha.1.23517.2

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop
 From Version 9.0.0-alpha.1.23512.1 -> To Version 9.0.0-alpha.1.23516.17 (parent: Microsoft.WindowsDesktop.App.Ref
@dreddy-work
Copy link
Member

dreddy-work commented Oct 17, 2023

infra issue : ShellJSInternalError: ENOSPC: no space left on device, write Rerunning.

@dreddy-work
Copy link
Member

WPF tests failed @singhashish-wpf / @lonitra

…ld 20231018.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-alpha.1.23513.1 -> To Version 9.0.0-alpha.1.23518.1

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop
 From Version 9.0.0-alpha.1.23512.1 -> To Version 9.0.0-alpha.1.23516.17 (parent: Microsoft.WindowsDesktop.App.Ref
…ld 20231018.2

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-alpha.1.23513.1 -> To Version 9.0.0-alpha.1.23518.2

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop
 From Version 9.0.0-alpha.1.23512.1 -> To Version 9.0.0-alpha.1.23518.1 (parent: Microsoft.WindowsDesktop.App.Ref
@dreddy-work
Copy link
Member

dreddy-work commented Oct 18, 2023

Tests getting wrong SDK version. @ViktorHofer / @mmitche any idea where 9.0.100-ci version of sdk coming from?

C:\h\w\9F9E08EB\p\d\sdk\9.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\targets\Microsoft.WinFX.targets(211,9): error MSB4062: The "Microsoft.Build.Tasks.Windows.MarkupCompilePass1" task could not be loaded from the assembly C:\h\w\9F9E08EB\p\d\sdk\9.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net8.0\PresentationBuildTasks.dll. Could not load file or assembly 'C:\h\w\9F9E08EB\p\d\sdk\9.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net8.0\PresentationBuildTasks.dll'. The system cannot find the path specified.

should these be updated by arcade? https://github.com/search?q=repo%3Adotnet%2Fwindowsdesktop+net8.0&type=code

@lonitra

…ld 20231018.10

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-alpha.1.23513.1 -> To Version 9.0.0-alpha.1.23518.10

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop
 From Version 9.0.0-alpha.1.23512.1 -> To Version 9.0.0-alpha.1.23518.3 (parent: Microsoft.WindowsDesktop.App.Ref
@ViktorHofer
Copy link
Member

AFAIK the 9.0.0-ci SDK is the live built one in the sdk repository. That's the expected one.

Regarding the PresentationBuildTasks.dll error, I see that we already talked about this one year ago: #28897. Maybe that helps? Sounds like the consensus last year was that wpf needs to build with a newer SDK?

should these be updated by arcade?

I believe that we need to wait for msbuild to target net9.0 before we can update the first two hits. NetMinimum is supposed to point to net8.0 as that's the minimum supported .NETCoreApp TFM when .NET 9 ships.

…ld 20231019.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-alpha.1.23513.1 -> To Version 9.0.0-alpha.1.23519.1

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop
 From Version 9.0.0-alpha.1.23512.1 -> To Version 9.0.0-alpha.1.23518.3 (parent: Microsoft.WindowsDesktop.App.Ref
ViktorHofer referenced this pull request in dotnet/wpf Oct 19, 2023
* Update TFM from .NET 8 to .NET 9

* Updating global.json
@ViktorHofer
Copy link
Member

Reason for the failure is dotnet/wpf@69985c9#r130418367

@singhashish-wpf
Copy link
Member

Pushed the suggested change. Thanks @ViktorHofer @dreddy-work

…ld 20231019.11

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-alpha.1.23513.1 -> To Version 9.0.0-alpha.1.23519.11

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop
 From Version 9.0.0-alpha.1.23512.1 -> To Version 9.0.0-alpha.1.23518.3 (parent: Microsoft.WindowsDesktop.App.Ref
…ld 20231019.18

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-alpha.1.23513.1 -> To Version 9.0.0-alpha.1.23519.18

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop
 From Version 9.0.0-alpha.1.23512.1 -> To Version 9.0.0-alpha.1.23519.4 (parent: Microsoft.WindowsDesktop.App.Ref
@ViktorHofer ViktorHofer enabled auto-merge (squash) October 20, 2023 06:51
@ViktorHofer ViktorHofer merged commit 575a7f7 into main Oct 20, 2023
19 of 20 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-c8968ff1-b707-4be2-8210-df831031a79c branch October 20, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants