Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append command line arguments to project specified RunArguments #37285

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

tmat
Copy link
Member

@tmat tmat commented Dec 2, 2023

Fixes dotnet/aspnetcore#52294

Customer Impact

dotnet watch customers unable to pass command line arguments to applications that are launched via a custom host specified by the project (e.g. Blazor WebAssembly).

Regression?

  • Yes
  • No

7.0

Workaround

As a workaround the customer can pass --no-hot-reload to dotnet watch in addition to the arguments. The behavior would then be the same as SDK 7, which implicitly disabled Hot Reload in this scenario.

Risk

  • High
  • [] Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@tmat tmat requested review from arunchndr and a team as code owners December 2, 2023 02:59
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 2, 2023
@tmat tmat changed the base branch from main to release/8.0.1xx December 2, 2023 03:00
@tmat tmat added Area-Watch Servicing-consider and removed Area-Infrastructure untriaged Request triage from a team member labels Dec 2, 2023
@tmat
Copy link
Member Author

tmat commented Dec 2, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tmat
Copy link
Member Author

tmat commented Dec 2, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@leecow leecow added this to the 8.0.2 milestone Dec 5, 2023
@tmat
Copy link
Member Author

tmat commented Dec 6, 2023

/azp run

@tmat tmat merged commit 373e57e into dotnet:release/8.0.1xx Dec 6, 2023
16 of 17 checks passed
@tmat tmat deleted the ProjectRunArguments branch December 6, 2023 01:56
Copy link

Pipelines were unable to run due to time out waiting for the pull request to finish merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor WebAssembly dotnet watch run --pathbase=/ doesn't work in .NET 8
3 participants