Respect the profile attribute on runtime packs #39402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
dsplaisted
approved these changes
Apr 9, 2024
src/Tasks/Microsoft.NET.Build.Tasks/ResolveRuntimePackAssets.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishTrimmedWindowsFormsAndWPFApps.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #37088, Need the windows desktop runtime pack changes, 4227, to flow for this change to take effect.
Add the existing
knownFrameworkReferenceprofile to theRuntimeFrameworkat theProcessFrameworkReferencestask. This matches the existing mechanism to add the profile to the target pack there. At theResolveRuntimePackAssets, use theRuntimeFrameworks,FrameworkReferences, and theResolvedRuntimePacksto find the correct profile if it exists, for the specificResolvedRuntimePack. Use this profile to filter the correct set of files from theRuntimeList.xmlin the runtime pack.