Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RuntimeHostConfigurationOption for COM descriptor support #40106

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Apr 10, 2024

Adds SDK logic for the feature switch introduced in dotnet/runtime#100693. Depends on dotnet/runtime#100881.

Together with dotnet/runtime#100881, fixes dotnet/runtime#100862.

@eerhardt
Copy link
Member

@sbomer - what's the default value for this new feature switch? It is currently blocking ingesting the latest runtime in dotnet/aspnetcore - dotnet/aspnetcore#55010

@sbomer
Copy link
Member Author

sbomer commented Apr 10, 2024

It'll be disabled by default for trimmed apps with dotnet/runtime#100881 and this change.

sbomer added a commit to dotnet/runtime that referenced this pull request Apr 10, 2024
Defaults the COM type descriptor feature switch to false in trimmed apps.
Depends on the SDK change dotnet/sdk#40106.
@sbomer sbomer enabled auto-merge (squash) April 11, 2024 15:25
@sbomer sbomer merged commit 9ae3243 into dotnet:main Apr 11, 2024
16 checks passed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
Defaults the COM type descriptor feature switch to false in trimmed apps.
Depends on the SDK change dotnet/sdk#40106.
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
Defaults the COM type descriptor feature switch to false in trimmed apps.
Depends on the SDK change dotnet/sdk#40106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ILLink untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compile native AoT ASP.NET Core application with latest .NET 9 daily build
3 participants