Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the workload resolver only light up for the specific entrypoint SDKs we control #41268

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

make the workload resolver only light up for the specific entrypoint SDKs we control #41268

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3a60947
make the workload resolver only light up for the specific entrypoint …
baronfel May 30, 2024
cbba7a1
update pattern to account for workload packs from all known workloads
baronfel Dec 4, 2024
37b88cb
use simpler, broader patterns
baronfel Dec 4, 2024
c6ca548
make sure the netfx resolver xml configs get the updates too
baronfel Dec 4, 2024
eca6019
use pattern that combines both workloads and known-sdk names for the …
baronfel Dec 7, 2024
3e0621d
Update patterns in generated netframework resolver
baronfel Dec 7, 2024
afed12e
try to include the generated xml file in the vs extension
baronfel Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...osoft.NET.Sdk.WorkloadMSBuildSdkResolver/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<SdkResolver>
<Path>..\..\Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver.dll</Path>
<ResolvableSdkPattern>Microsoft\.NET\.SDK\.WorkloadAutoImportPropsLocator|Microsoft\.NET\.SDK\.WorkloadManifestTargetsLocator|Microsoft\..*|Samsung\..*|GtkSharp\..*</ResolvableSdkPattern>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ResolvableSdkPattern>Microsoft\.NET\.SDK\.WorkloadAutoImportPropsLocator|Microsoft\.NET\.SDK\.WorkloadManifestTargetsLocator|Microsoft\..*|Samsung\..*|GtkSharp\..*</ResolvableSdkPattern>
<ResolvableSdkPattern>Microsoft\..*|Samsung\..*|GtkSharp\..*</ResolvableSdkPattern>

So it looks like anything starting with Microsoft., Samsung., or GtkSharp. will match. Given that, I don't think we need to special case the WorkloadAutoImportPropsLocator or WorkloadManifestTargetsLocator since they both start with Microsoft.

Did you look at all the packs from all the manifests (including Tizen) to make sure that they all match these patterns?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I can remove the specific matches. These broad patterns are sufficient to cover all the packs I could find on github - so there is a risk that there's some workload that isn't OSS and is broadly used that these patterns wouldn't cover.

</SdkResolver>
Loading