Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificate content type checking to Signature.cs #42025

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Add certificate content type checking to Signature.cs #42025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Cli/dotnet/Installer/Windows/Security/Signature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,14 @@ internal static class Signature
/// <remarks>This method does not perform any other chain validation like revocation checks, timestamping, etc.</remarks>
internal static unsafe int HasMicrosoftTrustedRoot(string path)
{
var certContentType = X509Certificate2.GetCertContentType(path);
if (certContentType != X509ContentType.Authenticode)
{
throw new CryptographicException($"Unexpected certificate content type, got '{certContentType}' instead of Authenticode.");
}

// Create an X509Certificate2 instance so we can access the certificate context and create a chain context.
#pragma warning disable SYSLIB0057 // can't use X509CertificateLoader here since it tries to parse the file as a certificate
#pragma warning disable SYSLIB0057 // we need Authenticode support which isn't available from X509CertificateLoader
using X509Certificate2 certificate = new(path);
#pragma warning restore SYSLIB0057

Expand Down
Loading