Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx] Update dependencies from dotnet/sourcelink #43835

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 2, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/sourcelink

  • Subscription: 40d15540-bfdd-42a2-1006-08dcbc30275f
  • Build: 20241001.2
  • Date Produced: October 2, 2024 12:30:08 AM UTC
  • Commit: da0cf0ba63bd8f346ab6eff998d1c9bba092541a
  • Branch: refs/heads/main

…0241001.2

Microsoft.SourceBuild.Intermediate.sourcelink , Microsoft.Build.Tasks.Git , Microsoft.SourceLink.AzureRepos.Git , Microsoft.SourceLink.Bitbucket.Git , Microsoft.SourceLink.Common , Microsoft.SourceLink.GitHub , Microsoft.SourceLink.GitLab
 From Version 9.0.0-beta.24480.2 -> To Version 9.0.0-beta.24501.2
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Oct 2, 2024
@nagilson
Copy link
Member

nagilson commented Oct 2, 2024

@dotnet/source-build-contrib SourceLinkTests.WithNoRemoteNoCommit This test seems to not print the entire error correctly when it fails, and it is failng because of the word 'warning' in its output somewhere which is truncated. Can you PTAL?

@MichaelSimons
Copy link
Member

@dotnet/source-build-contrib SourceLinkTests.WithNoRemoteNoCommit This test seems to not print the entire error correctly when it fails, and it is failng because of the word 'warning' in its output somewhere which is truncated. Can you PTAL?

Why is source-build being asked to investigate? I am not making the connection to source-build. This is not happening in a source-build leg.

@nagilson
Copy link
Member

nagilson commented Oct 2, 2024

I pinged sourcebuild because the only changes I see are from source-build-reference-packages updates. We also don't have a sourcelink alias. @ViktorHofer @tmat Are you more appropriate contacts for this?

@nagilson
Copy link
Member

nagilson commented Oct 2, 2024

@marcpopMSFT It looks like the maestro bot is allowed to merge its own PRs without human intervention on the sourcelink repo dotnet/sourcelink#1288. I'm pretty sure that's against the policy considering we were asked not to do that; but maybe it's considered OK since they aren't the end point?

@marcpopMSFT
Copy link
Member

@marcpopMSFT It looks like the maestro bot is allowed to merge its own PRs without human intervention on the sourcelink repo dotnet/sourcelink#1288. I'm pretty sure that's against the policy considering we were asked not to do that; but maybe it's considered OK since they aren't the end point?

I'll have to defer to @tmat on that

@MichaelSimons
Copy link
Member

I pinged sourcebuild because the only changes I see are from source-build-reference-packages updates. We also don't have a sourcelink alias.

An SBRP update would have no effect outside of source-build.

@marcpopMSFT
Copy link
Member

/azp run dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@nagilson nagilson merged commit 5a0344e into release/9.0.1xx Oct 3, 2024
34 of 35 checks passed
@nagilson nagilson deleted the darc-release/9.0.1xx-8bb75a81-8773-42c5-a9b7-66b2720ca394 branch October 3, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow Area-SourceLink untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants