-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix port error when fallback to http #44050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the rebase - this seems very clear. Do you have any idea how this could be tested via unit tests? Maybe via the pattern that @tmds did for this auth handler PR - a mock HttpHandler?
src/Containers/Microsoft.NET.Build.Containers/FallbackToHttpMessageHandler.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/FallbackToHttpMessageHandler.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/FallbackToHttpMessageHandler.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests!
@baronfel the work is done,can you spare some time to check? |
This LGTM, thanks @dameng324! I kicked CI to see if those two failing legs can get green. If so, we'll merge and I'll backport the fix to 8.0.400 and 9.0.100 and work on getting approval for those. |
/backport to release/8.0.4xx |
/backport to release/9.0.1xx |
Started backporting to release/8.0.4xx: https://github.com/dotnet/sdk/actions/runs/11370820390 |
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/11370821680 |
As discussed in previous PR: #43620,
I pass the original
registryName
toFallbackToHttpMessageHandler
and check it if contains a port or not. If not, set theuriBuilder.Port = -1
.For summary. It should behave like this:
Fixed: #43618 , dotnet/sdk-container-builds#588