-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VMR] Build failure with portable RID (e.g. /p:TargetRid=linux-x64) #3131
Comments
|
Adding |
cc @tmds |
There are some changes on aspnetcore 7.0 branch for eliminating the portable build. The PRs against the installer repo haven't been backported yet (dotnet/installer#14549 and dotnet/installer#14938). Backporting those may fix this issue. |
Funny story, I think the 7.0 aspnetcore changes (specifically dotnet/aspnetcore#44978) are the problem, not the cure.
Locally, removing one of the duplicated dependencies progresses the build further. Without the duplicate dependency, |
The aspnetcore build still fails, mind you, but later in the build:
|
Well that's fascinating. In my non-portable build, those three assemblies exist only in |
OK, no, the 2-assembly thing is a weird problem with a dirty build. Doing a 100% clean build, this is enough to make the build work: index 6c44830a0..904a23489 100644
--- a/src/aspnetcore/eng/Dependencies.props
+++ b/src/aspnetcore/eng/Dependencies.props
@@ -100,7 +100,6 @@ and are generated based on the last package release.
<LatestPackageReference Include="Microsoft.NETCore.App.Runtime.win-arm64" />
<LatestPackageReference Include="Microsoft.NETCore.App.Runtime.osx-x64" />
<LatestPackageReference Include="Microsoft.NETCore.App.Runtime.osx-arm64" />
- <LatestPackageReference Include="Microsoft.NETCore.App.Runtime.linux-x64" />
<LatestPackageReference Include="Microsoft.NETCore.App.Runtime.linux-arm" />
<LatestPackageReference Include="Microsoft.NETCore.App.Runtime.linux-arm64" />
<LatestPackageReference Include="Microsoft.NETCore.App.Runtime.linux-musl-x64" />
@@ -117,7 +116,6 @@ and are generated based on the last package release.
<LatestPackageReference Include="Microsoft.NETCore.App.Crossgen2.linux-musl-arm" />
<LatestPackageReference Include="Microsoft.NETCore.App.Crossgen2.linux-musl-arm64" />
<LatestPackageReference Include="Microsoft.NETCore.App.Crossgen2.linux-musl-x64" />
- <LatestPackageReference Include="Microsoft.NETCore.App.Crossgen2.linux-x64" />
<LatestPackageReference Include="Microsoft.NETCore.App.Crossgen2.win-x64" />
<LatestPackageReference Include="Microsoft.NETCore.App.Crossgen2.win-x86" />
<LatestPackageReference Include="Microsoft.NETCore.App.Crossgen2.win-arm" />
|
Got a Mac build. I'll post patches & file issues tomorrow morning, since changes are needed. |
I'm still getting this problem on 9.0.0-preview.2 unless I make the same change described in #3131 (comment) (removing the duplicate references). I also had a similar problem in 8.0 releases, which I described here: dotnet/installer#15163 (comment). I should have probably posted that comment on this issue instead. My fix from 8.0 no longer applies, but I verified that aspnetcore is building with |
I'm still working on the exact root cause, but I wanted to have a written record somewhere other than internal Teams.
Building for a generic, portable RID fails currently with the VMR, in
aspnetcore
, citing that it can't find the crossgen2 binary. Looking at the build, and comparing to a "good"ubuntu.22.04-x64
build, it seems the crossgen2 nupkg is created as expected during the runtime build, but never restored in aspnetcore.It appears the build explicitly rejects most of the package references from earlier in the build, in fact, citing that they do not need to be explicitly depended on because they're part of the SDK.
This also blocks building an osx-x64 RID build on Mac.
The text was updated successfully, but these errors were encountered: