Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Arcade and other tool packages #1237

Merged
merged 138 commits into from
Oct 17, 2019
Merged
Show file tree
Hide file tree
Changes from 51 commits
Commits
Show all changes
138 commits
Select commit Hold shift + click to select a range
8348aed
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Sep 26, 2019
6581f0c
Re-destabilize for building 3.0.1 dev builds.
crummel Oct 1, 2019
c480abd
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Oct 1, 2019
d428ac0
Update websdk patch
crummel Oct 1, 2019
fb8e52c
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Oct 1, 2019
7e6ae31
Make sure we fail the build when build script fails
crummel Oct 2, 2019
4044769
Upgrade SDK to 3.0.100
crummel Oct 2, 2019
fe3b15c
Update patches
crummel Oct 2, 2019
60f0ed9
Fix patch again
crummel Oct 2, 2019
bdeaf25
Really fix the patch
crummel Oct 2, 2019
5b467eb
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Oct 2, 2019
af3a19a
Turn warnings as errors off for arcade
crummel Oct 2, 2019
b44ac7a
Warnings as errors also off for templating
crummel Oct 2, 2019
3b2e755
Fix patch again
crummel Oct 2, 2019
30d8f16
Remove patch that's no longer needed.
crummel Oct 2, 2019
74600c5
We don't have the Windows package, so try faking it.
crummel Oct 2, 2019
28deb04
Try a different approach to the ASP.NET version.
crummel Oct 2, 2019
42ea01d
Add logging back to source-build's build itself
crummel Oct 2, 2019
2c39fe4
Rework stable versions so repos can be stable independent of each other.
crummel Oct 3, 2019
0907e3c
Fix function casing
crummel Oct 3, 2019
a08fa3a
Restore patch for now
crummel Oct 3, 2019
89f9e2a
Update online prebuilt baseline
crummel Oct 3, 2019
f016d90
Add patch for corefx not to call dotnet without a path
crummel Oct 3, 2019
6126f38
Fix CoreFX patch
crummel Oct 3, 2019
89432e0
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Oct 3, 2019
c9b8f20
fix websdk patch
crummel Oct 3, 2019
6327200
Same patch for core-setup
crummel Oct 3, 2019
142041f
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Oct 4, 2019
9ae0206
fix websdk patch
crummel Oct 4, 2019
9f4eebb
Add another psuedo package for CLI
crummel Oct 4, 2019
46c7564
Another psuedo package for toolset
crummel Oct 4, 2019
69ff7b6
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Oct 4, 2019
0650e6f
Remove upstreamed patch
crummel Oct 4, 2019
6715146
Update core-sdk ASP.NET version patch
crummel Oct 4, 2019
2401514
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Oct 5, 2019
1f8b55c
Update Arcade
crummel Sep 18, 2019
9a55390
Update patches
crummel Sep 18, 2019
8095549
Fix patch
crummel Sep 18, 2019
1f79c16
CoreFxTesting SDK no longer produced
crummel Sep 18, 2019
7dfe791
Revert "CoreFxTesting SDK no longer produced"
crummel Sep 18, 2019
58ecf46
Upgrade SDK
crummel Sep 19, 2019
930f635
Add extra restore sources for core-setup
crummel Sep 20, 2019
33b46c3
Patch Arcade to not reset RestoreSources
crummel Sep 20, 2019
ce7d731
Add RestoreSources to Xliff
crummel Sep 20, 2019
763e0f7
Update RestoreSources for MSBuild
crummel Sep 20, 2019
9a96bb7
Fix Arcade RestoreSources patch
crummel Sep 20, 2019
a350723
turn warnings as errors off for templating
crummel Sep 21, 2019
f631596
Revert "Try Tom' RID patch"
crummel Sep 21, 2019
ebc5baf
Restore sources for CLI and SDK
crummel Sep 21, 2019
b89457f
Fix CoreCLR restore sources
crummel Sep 21, 2019
3ea8331
Update sourcelink version
crummel Sep 21, 2019
40eac06
Testing just removing this patch
crummel Sep 21, 2019
bd3ced5
Try CoreFX too
crummel Sep 22, 2019
a191c9c
Try straight revert
crummel Sep 22, 2019
3bfab7f
wip
crummel Sep 27, 2019
476eadb
Remove cherry-picked Arcade patches
crummel Sep 27, 2019
9c09659
Fix badly merged patches
crummel Sep 27, 2019
0dfc869
Update CoreFx's NuGet.config
crummel Sep 27, 2019
d3bc861
Add arcade debugging pach
crummel Oct 2, 2019
d9e22a7
Another debug attempt
crummel Oct 2, 2019
5ded5e3
Turn warnAsError off for arcade and core-setup
crummel Oct 2, 2019
ab322ee
More debugging
crummel Oct 2, 2019
7bb41fc
Fix debugging patch
crummel Oct 2, 2019
e84c98d
Disable parallel builds and nodereuse
crummel Oct 2, 2019
c99ea2e
Fix patch
crummel Oct 2, 2019
ff4fde1
Think Portable should handle all of this now
crummel Oct 3, 2019
5a1effb
Add NuGet.config to cli.proj.
crummel Oct 3, 2019
bf83798
fix debugging warning
crummel Oct 3, 2019
a687350
Remove debugging patch
crummel Oct 3, 2019
9dda9ea
Add NuGet.config to core-sdk.proj.
crummel Oct 3, 2019
ff7768d
Try core-setup SDK upgrade patch
crummel Oct 4, 2019
2151f11
Add smoke-test directory to .gitignore
crummel Oct 4, 2019
856867f
Try with just OutputRid
crummel Oct 4, 2019
9f20817
targetrid only
crummel Oct 4, 2019
6293521
get rid of extra args
crummel Oct 4, 2019
322d814
use correct parameters
crummel Oct 4, 2019
32d1bd4
another psuedo package for core-sdk
crummel Oct 5, 2019
31c8897
Add restore source and remove parallel builds
crummel Oct 5, 2019
8fcfe0c
Another psuedo package
crummel Oct 5, 2019
9de8d89
Update production prebuilt baseline
crummel Oct 6, 2019
ab20414
another psuedo package
crummel Oct 6, 2019
d7b8fcc
Copy Arcade to source-built prebuilts
crummel Oct 6, 2019
17f06b1
more source-built packages
crummel Oct 6, 2019
9da5ed7
more packages
crummel Oct 7, 2019
bf56219
Update sourcelink
crummel Oct 7, 2019
a8f4887
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Oct 7, 2019
9918e4a
Update source built artifacts version to 3.0 release version
dseefeld Oct 7, 2019
516551b
Patch sourcelink to not build full fx
crummel Oct 7, 2019
ab61aae
disable warnings as errors for sourcelink
crummel Oct 7, 2019
ddcb495
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Oct 7, 2019
a46f90c
fix nuspec tfm
crummel Oct 7, 2019
6bcbcde
more tfm nuspec
crummel Oct 7, 2019
667af0f
more tfm
crummel Oct 7, 2019
c64a236
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Oct 8, 2019
655d2d2
moree fullfx
crummel Oct 8, 2019
cd6512d
more target framework
crummel Oct 8, 2019
caedca0
Update dependencies from https://github.com/dotnet/core-sdk build 201…
dotnet-maestro[bot] Oct 8, 2019
f1085d6
more tfm
crummel Oct 8, 2019
5f4c33c
more target framework
crummel Oct 10, 2019
81876de
add arcade path to not call dotnet without path
crummel Oct 10, 2019
e23bbe8
override netstadard version for standard
crummel Oct 10, 2019
083fe3e
use same base library package offline and online
crummel Oct 10, 2019
39ef85b
destabilize
crummel Oct 10, 2019
2a2cec5
Merge remote-tracking branch 'upstream/darc-release/3.0-b4a326b9-5d30…
crummel Oct 10, 2019
943984f
Merge remote-tracking branch 'dan/updateSourceBuiltVersion' into arca…
crummel Oct 10, 2019
8991d2a
Patch upgrade
crummel Oct 10, 2019
824cbb0
Merge remote-tracking branch 'upstream/release/3.0' into arcadeUpgrade
crummel Oct 10, 2019
cd52233
Always pass core-seutp RID to core-sdk
crummel Oct 10, 2019
0ba3a5c
Patch arcade to use ref version of CodeAnalysis
crummel Oct 10, 2019
efdc245
Pass host RID to ASP.NET
crummel Oct 10, 2019
1e228b1
Add OSName to CLI proj.
crummel Oct 10, 2019
8404093
Update production prebuilt baseline
crummel Oct 10, 2019
333da63
Update smoke-test feed to official release
crummel Oct 10, 2019
4de651a
might not need that
crummel Oct 11, 2019
2108a5d
Merge remote-tracking branch 'upstream/release/3.0' into arcadeUpgrade
crummel Oct 11, 2019
7f5c10e
Patch out some standard source-build-specific stuff
crummel Oct 14, 2019
a377e5c
Merge remote-tracking branch 'upstream/release/3.0' into arcadeUpgrade
crummel Oct 14, 2019
c37d2a9
Doc doesn't work
crummel Oct 14, 2019
3d511fa
Try excluding all netstandard.library DLLs
crummel Oct 14, 2019
01513c7
Try restoring 2.0.3 NETStandard.Lib
crummel Oct 15, 2019
e7247ed
Merge remote-tracking branch 'upstream/release/3.0' into arcadeUpgrade
crummel Oct 15, 2019
bf721a8
osx fix
crummel Oct 16, 2019
77a9636
need RID-specific packages before they are built
crummel Oct 16, 2019
139419c
Need to use the stage1 version of core-setup in corefx
crummel Oct 16, 2019
1c9fa68
more bootstrapping
crummel Oct 16, 2019
aa1fea8
another core-seut pbootstrap package
crummel Oct 16, 2019
20b597f
more bootstrapping packages
crummel Oct 16, 2019
3ad4f2b
fix core-setup restore sources
crummel Oct 16, 2019
a9591da
Patch websdk to not call dotnet without a path
crummel Oct 16, 2019
2662ca9
patch toolset to not call dotnet without a path
crummel Oct 16, 2019
3f096a3
Fix missing property for OSX
crummel Oct 16, 2019
ff9a226
Update offline prebuilt baseline
crummel Oct 16, 2019
d92aaef
Changed this in another PR to use set -e instead.
crummel Oct 16, 2019
49774c7
Fix some typos
crummel Oct 16, 2019
e8f5184
exclude standard
crummel Oct 17, 2019
a26075e
smoke test also needs new feed
crummel Oct 17, 2019
e0cb7fd
Fix typo in OSX package name
crummel Oct 17, 2019
18e1a83
update prebuilt baseline for osx
crummel Oct 17, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ config.ps1
### source-build ###
prebuilt/
msbuild.binlog
testing-smoke/

# Exists temporarily during build. Interferes with VersionTools'
# UpdateDependenciesAndSubmitPullRequest: if no upgrades are performed, the
Expand Down
3 changes: 3 additions & 0 deletions build-source-tarball.sh
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,9 @@ done
echo 'Copying source-built packages to tarball to replace packages needed before they are built...'
mkdir -p $TARBALL_ROOT/packages/source-built
cp -r $SCRIPT_ROOT/Tools/source-built/coreclr-tools $TARBALL_ROOT/packages/source-built/
cp $SCRIPT_ROOT/bin/obj/x64/Release/blob-feed/packages/*Arcade*.nupkg $TARBALL_ROOT/packages/source-built/
cp $SCRIPT_ROOT/bin/obj/x64/Release/blob-feed/packages/*SourceLink*.nupkg $TARBALL_ROOT/packages/source-built/
cp $SCRIPT_ROOT/bin/obj/x64/Release/blob-feed/packages/*Build*Tasks*.nupkg $TARBALL_ROOT/packages/source-built/
crummel marked this conversation as resolved.
Show resolved Hide resolved

# Setup package version props to include both source-built and running PackageVersions.props
mkdir --parents $TARBALL_ROOT/bin/obj/x64/Release/
Expand Down
8 changes: 4 additions & 4 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.19381.1">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.19463.3">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>8f3c22397990aeb20a88690b51dad4b33f21e7ff</Sha>
<Sha>ce459ae07c3d7a1e68251268855e0bc7b3d97f75</Sha>
</Dependency>
<Dependency Name="Private.SourceBuild.ReferencePackages" Version="1.0.0-beta.19504.1">
<Uri>https://github.com/dotnet/source-build-reference-packages</Uri>
<Sha>2ffab5d89396ae7150331e6898661b5aeaa63d7e</Sha>
</Dependency>
</ToolsetDependencies>
<ProductDependencies>
<Dependency Name="sourcelink" Version="1.0.0-beta2-19351-01">
<Dependency Name="Microsoft.Build.Tasks.Git" Version="1.0.0-beta2-19367-01">
<Uri>https://github.com/dotnet/sourcelink</Uri>
<Sha>51310e65e75010467993f793e1739d1a1dad50c5</Sha>
<Sha>855afb5af9ea79e63dd9c051a7cfe0941bbb5ced</Sha>
</Dependency>
<!-- this is pinned to work around https://github.com/dotnet/arcade/issues/3518 -->
<!-- if XDT is updated before that issue is fixed, this should be updated. After the issue is fixed, it should be unpinned. -->
Expand Down
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"tools": {
"dotnet": "3.0.100-preview7-012821"
"dotnet": "3.0.100"
},
"msbuild-sdks": {
"Microsoft.Build.CentralPackageVersions": "2.0.1",
Expand Down
6 changes: 3 additions & 3 deletions patches/arcade/0001-Enable-sourcelink-in-sourcebuild.patch
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
From c255c95b8b488d81349ccecd47f1966e4aa9b713 Mon Sep 17 00:00:00 2001
From 203f9d3b13a9c30442159361d9333ae6144346c7 Mon Sep 17 00:00:00 2001
From: Chris Rummel <crummel@microsoft.com>
Date: Wed, 7 Aug 2019 19:23:07 -0500
Subject: [PATCH] Enable sourcelink in sourcebuild.
Subject: [PATCH 1/3] Enable sourcelink in sourcebuild.

---
.../tools/RepositoryInfo.targets | 14 +-------------
Expand Down Expand Up @@ -37,5 +37,5 @@ index 550ad298..8d31d833 100644
<SourceRoot Include="$(RepoRoot)" />
</ItemGroup>
--
2.21.0
2.18.0

Original file line number Diff line number Diff line change
@@ -1,21 +1,33 @@
From 2f4170e475fc334aeb0fb5e5b612245a05d36dfd Mon Sep 17 00:00:00 2001
From fd66f02bea54d60c13cd3a3652a01b1987d091c0 Mon Sep 17 00:00:00 2001
From: Nikola Milosavljevic <nikolam@microsoft.com>
Date: Fri, 6 Sep 2019 18:18:33 +0000
Subject: [PATCH 2/2] Do not build .NET Fx binaries in source build.
Subject: [PATCH 2/3] Do not build .NET Fx binaries in source build.

---
eng/Versions.props | 2 +-
src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj | 1 +
.../src/Microsoft.DotNet.Build.Tasks.Configuration.csproj | 3 ++-
.../src/Microsoft.DotNet.Build.Tasks.Packaging.csproj | 1 +
.../Microsoft.DotNet.CoreFxTesting.csproj | 1 +
.../Microsoft.DotNet.Deployment.Tasks.Links.csproj | 1 +
src/Microsoft.DotNet.GenFacades/Microsoft.DotNet.GenFacades.csproj | 3 ++-
src/Microsoft.DotNet.SignTool/Microsoft.DotNet.SignTool.csproj | 1 +
8 files changed, 10 insertions(+), 3 deletions(-)
Directory.Build.props | 1 +
eng/Versions.props | 2 +-
.../Microsoft.DotNet.Arcade.Sdk.csproj | 1 +
.../src/Microsoft.DotNet.Build.Tasks.Configuration.csproj | 3 ++-
.../src/Microsoft.DotNet.Build.Tasks.Packaging.csproj | 1 +
.../Microsoft.DotNet.CoreFxTesting.csproj | 1 +
.../Microsoft.DotNet.Deployment.Tasks.Links.csproj | 1 +
.../Microsoft.DotNet.GenFacades.csproj | 3 ++-
src/Microsoft.DotNet.SignTool/Microsoft.DotNet.SignTool.csproj | 1 +
9 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index eba8e1c9..06382559 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -14,5 +14,6 @@
Tools and packages produced by this repository support infrastructure and are not shipping on NuGet or via any other official channel.
-->
<IsShipping>false</IsShipping>
+ <NoWarn>$(NoWarn);NU5128</NoWarn>
</PropertyGroup>
</Project>
diff --git a/eng/Versions.props b/eng/Versions.props
index 249e6d2..bf7a2ed 100644
index bf38e650..2c945967 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -6,7 +6,7 @@
Expand All @@ -28,7 +40,7 @@ index 249e6d2..bf7a2ed 100644
<CommandLineParserVersion>2.2.1</CommandLineParserVersion>
<CredentialManagementVersion>1.0.2</CredentialManagementVersion>
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj b/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj
index aaaf4da..f16405e 100644
index aaaf4dac..f16405e7 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj
+++ b/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj
@@ -2,6 +2,7 @@
Expand All @@ -40,7 +52,7 @@ index aaaf4da..f16405e 100644
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<ExcludeFromSourceBuild>false</ExcludeFromSourceBuild>
diff --git a/src/Microsoft.DotNet.Build.Tasks.Configuration/src/Microsoft.DotNet.Build.Tasks.Configuration.csproj b/src/Microsoft.DotNet.Build.Tasks.Configuration/src/Microsoft.DotNet.Build.Tasks.Configuration.csproj
index 1ee3064..ce6a5e5 100644
index 1ee3064c..ce6a5e5e 100644
--- a/src/Microsoft.DotNet.Build.Tasks.Configuration/src/Microsoft.DotNet.Build.Tasks.Configuration.csproj
+++ b/src/Microsoft.DotNet.Build.Tasks.Configuration/src/Microsoft.DotNet.Build.Tasks.Configuration.csproj
@@ -2,6 +2,7 @@
Expand All @@ -59,7 +71,7 @@ index 1ee3064..ce6a5e5 100644
\ No newline at end of file
+</Project>
diff --git a/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj b/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj
index 5dfd052..2f771f9 100644
index 678ba714..955d343b 100644
--- a/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj
+++ b/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj
@@ -2,6 +2,7 @@
Expand All @@ -71,7 +83,7 @@ index 5dfd052..2f771f9 100644
<PackageType>MSBuildSdk</PackageType>
<IncludeBuildOutput>false</IncludeBuildOutput>
diff --git a/src/Microsoft.DotNet.CoreFxTesting/Microsoft.DotNet.CoreFxTesting.csproj b/src/Microsoft.DotNet.CoreFxTesting/Microsoft.DotNet.CoreFxTesting.csproj
index 8bd6963..694e338 100644
index 78d8c94c..33e90e49 100644
--- a/src/Microsoft.DotNet.CoreFxTesting/Microsoft.DotNet.CoreFxTesting.csproj
+++ b/src/Microsoft.DotNet.CoreFxTesting/Microsoft.DotNet.CoreFxTesting.csproj
@@ -2,6 +2,7 @@
Expand All @@ -81,9 +93,9 @@ index 8bd6963..694e338 100644
+ <TargetFrameworks Condition="'$(DotNetBuildFromSource)' == 'true'">netcoreapp2.1</TargetFrameworks>
<Description>This package provides support for running tests inside CoreFx.</Description>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>
<ExcludeFromSourceBuild>true</ExcludeFromSourceBuild>
diff --git a/src/Microsoft.DotNet.Deployment.Tasks.Links/Microsoft.DotNet.Deployment.Tasks.Links.csproj b/src/Microsoft.DotNet.Deployment.Tasks.Links/Microsoft.DotNet.Deployment.Tasks.Links.csproj
index ed385c1..7314a27 100644
index 5adb4419..43f0b4e5 100644
--- a/src/Microsoft.DotNet.Deployment.Tasks.Links/Microsoft.DotNet.Deployment.Tasks.Links.csproj
+++ b/src/Microsoft.DotNet.Deployment.Tasks.Links/Microsoft.DotNet.Deployment.Tasks.Links.csproj
@@ -3,6 +3,7 @@
Expand All @@ -95,7 +107,7 @@ index ed385c1..7314a27 100644
<IsPackable>true</IsPackable>
<Description>Aka.ms link manager</Description>
diff --git a/src/Microsoft.DotNet.GenFacades/Microsoft.DotNet.GenFacades.csproj b/src/Microsoft.DotNet.GenFacades/Microsoft.DotNet.GenFacades.csproj
index 196bc8d..04f3e5b 100644
index 8936c1f1..6678ac40 100644
--- a/src/Microsoft.DotNet.GenFacades/Microsoft.DotNet.GenFacades.csproj
+++ b/src/Microsoft.DotNet.GenFacades/Microsoft.DotNet.GenFacades.csproj
@@ -2,6 +2,7 @@
Expand All @@ -106,15 +118,15 @@ index 196bc8d..04f3e5b 100644
<ExcludeFromSourceBuild>false</ExcludeFromSourceBuild>
<PackageType>MSBuildSdk</PackageType>
<IncludeBuildOutput>false</IncludeBuildOutput>
@@ -49,4 +50,4 @@
@@ -58,4 +59,4 @@

<Import Project="$(RepoRoot)eng\BuildTask.targets" />

-</Project>
\ No newline at end of file
+</Project>
diff --git a/src/Microsoft.DotNet.SignTool/Microsoft.DotNet.SignTool.csproj b/src/Microsoft.DotNet.SignTool/Microsoft.DotNet.SignTool.csproj
index a201af8..e84959e 100644
index a201af86..e84959e2 100644
--- a/src/Microsoft.DotNet.SignTool/Microsoft.DotNet.SignTool.csproj
+++ b/src/Microsoft.DotNet.SignTool/Microsoft.DotNet.SignTool.csproj
@@ -2,6 +2,7 @@
Expand All @@ -126,5 +138,5 @@ index a201af8..e84959e 100644
<LangVersion>Latest</LangVersion>
<IsPackable>true</IsPackable>
--
1.8.3.1
2.18.0

24 changes: 24 additions & 0 deletions patches/arcade/0003-Build-CoreFxTesting-in-source-build.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
From fb40a09831a06ee786c884917813890959e1956f Mon Sep 17 00:00:00 2001
From: Chris Rummel <crummel@microsoft.com>
Date: Tue, 24 Sep 2019 11:39:15 -0500
Subject: [PATCH 3/3] Build CoreFxTesting in source-build

---
.../Microsoft.DotNet.CoreFxTesting.csproj | 1 -
1 file changed, 1 deletion(-)

diff --git a/src/Microsoft.DotNet.CoreFxTesting/Microsoft.DotNet.CoreFxTesting.csproj b/src/Microsoft.DotNet.CoreFxTesting/Microsoft.DotNet.CoreFxTesting.csproj
index 33e90e49..694e3381 100644
--- a/src/Microsoft.DotNet.CoreFxTesting/Microsoft.DotNet.CoreFxTesting.csproj
+++ b/src/Microsoft.DotNet.CoreFxTesting/Microsoft.DotNet.CoreFxTesting.csproj
@@ -5,7 +5,6 @@
<TargetFrameworks Condition="'$(DotNetBuildFromSource)' == 'true'">netcoreapp2.1</TargetFrameworks>
<Description>This package provides support for running tests inside CoreFx.</Description>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
- <ExcludeFromSourceBuild>true</ExcludeFromSourceBuild>
</PropertyGroup>

<ItemGroup>
--
2.18.0

This file was deleted.

Loading