Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marking packages as stable in preparation for 1.2 release #358

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Marking packages as stable in preparation for 1.2 release #358

merged 2 commits into from
Jun 29, 2023

Conversation

joperezr
Copy link
Member

adityamandaleeka
adityamandaleeka approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@adityamandaleeka adityamandaleeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looking at the history, did we not do this for 1.1?

@joperezr joperezr added this to the 1.2 milestone Jun 28, 2023
@joperezr
Copy link
Member Author

Good question, I hadn't noticed. Technically speaking you don't necesarilly need this change as you can queue a build and then explicitly pass the argument /p:DotNetFinalVersionKind=release through AzDOs options.

@joperezr joperezr merged commit 5db005e into main Jun 29, 2023
@joperezr joperezr deleted the 12Release branch June 29, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamandaleeka adityamandaleeka adityamandaleeka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@joperezr @adityamandaleeka @twsouthwick