DerivedSymbol implementation #1194
Conversation
…nsofrm of another symbol value
| if (parameters.TryGetParameterDefinition(config.VariableName, out ITemplateParameter existingParam)) | ||
| { // Derived parameters already have a definition, but need value form processing. | ||
| // When the param already exists, use its definition. | ||
| p = (Parameter)existingParam; |
There was a problem hiding this comment.
Let's set IsVariable = true on the existing parameter for consistency (even though it's never used right now) and make all of the other macros behave this way too.
We should probably make this comment a little more clear as well (since we're in the value forms macro) that the existing parameter must be reused to allow the processing of value forms declared on the derived symbol type later in the thing that deals with value forms for parameter type symbols.
We should also make sure that the processing of the value forms macro for the derived symbol happens before value forms for parameters/derived symbols happen
| @@ -571,6 +577,14 @@ private IGlobalRunConfig ProduceOperationSetup(SpecialOperationConfigParams defa | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if (symbol.Value is DerivedSymbol derivedSymbol) | |||
There was a problem hiding this comment.
This one should move to above the replaces check (to set up the map between the value of the source symbol and the value of the derived symbol), then the block for handling the value forms of parameter symbols should be made to handle BaseSomethingSymbol
…rwrite existing symbols if they exist
symbol whose value is a value-form transform of another symbol value