-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .NET 5 templates with net5.0 tfm #2310
Conversation
thank you for the contributions @ViktorHofer ! I will test the changes. |
@grinrag can we merge this? this will require a new SDK anyway to make restore and the sdk parsing logic work. |
@phenning - How would this change impact the templates displayed in VS? |
Pretty severely. we really needed time to proof VS for this change. |
@ViktorHofer - This will break a lot of our VS tooling scenarios. Can we make this change only in preview3 branch and not in preview2 branch so that there is time for tooling to react to this change. |
How is the 5.0-preview2 branch connected to VS? That branch versions with dotnet. If you need to ship these templates to VS as well the I recommend creating a 16.x branch and not include my template change. That said I know that nuget ships the net5.0 compatibility feature to VS for 16.6. |
We are talking about release timing, not a hard dependency here. |
I see, thanks for clarifying.
Unfortunately not, as for 5.0-preview2 the goal is to land the net5.0 TFM change. Here's the tracking issue: dotnet/sdk#10756.
cc @leecow @SteveCarrollMSFT |
Contributes towards dotnet/sdk#10756
cc @grinrag and Jose Aguilar (what's your GH handle? ;))