Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET 5 templates with net5.0 tfm #2310

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 12, 2020

Contributes towards dotnet/sdk#10756

cc @grinrag and Jose Aguilar (what's your GH handle? ;))

@ViktorHofer ViktorHofer mentioned this pull request Mar 12, 2020
10 tasks
@genalt
Copy link
Contributor

genalt commented Mar 12, 2020

thank you for the contributions @ViktorHofer ! I will test the changes.
cc @donJoseLuis

@ViktorHofer
Copy link
Member Author

@grinrag can we merge this? this will require a new SDK anyway to make restore and the sdk parsing logic work.

@genalt genalt merged commit 6d990f4 into dotnet:master Mar 12, 2020
@vijayrkn
Copy link
Contributor

@phenning - How would this change impact the templates displayed in VS?

@phenning
Copy link
Contributor

Pretty severely. we really needed time to proof VS for this change.

@vijayrkn
Copy link
Contributor

@ViktorHofer - This will break a lot of our VS tooling scenarios. Can we make this change only in preview3 branch and not in preview2 branch so that there is time for tooling to react to this change.

@ViktorHofer
Copy link
Member Author

How is the 5.0-preview2 branch connected to VS? That branch versions with dotnet. If you need to ship these templates to VS as well the I recommend creating a 16.x branch and not include my template change. That said I know that nuget ships the net5.0 compatibility feature to VS for 16.6.

@ViktorHofer ViktorHofer deleted the Net50Tfm branch March 14, 2020 08:51
@phenning
Copy link
Contributor

We are talking about release timing, not a hard dependency here.

@ViktorHofer
Copy link
Member Author

I see, thanks for clarifying.

Can we make this change only in preview3 branch and not in preview2 branch so that there is time for tooling to react to this change.

Unfortunately not, as for 5.0-preview2 the goal is to land the net5.0 TFM change. Here's the tracking issue: dotnet/sdk#10756.

Pretty severely. we really needed time to proof VS for this change.

cc @leecow @SteveCarrollMSFT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants