Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block all unsafe ports #5380

Merged
merged 3 commits into from
Oct 10, 2022
Merged

block all unsafe ports #5380

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
756344d
block all unsafe ports
kasperk81 Oct 6, 2022
34fd351
fb
kasperk81 Oct 7, 2022
f862527
sort
kasperk81 Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions ...ft.TemplateEngine.Orchestrator.RunnableProjects/Macros/Config/GeneratePortNumberConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,31 @@ namespace Microsoft.TemplateEngine.Orchestrator.RunnableProjects.Macros.Config
{
internal class GeneratePortNumberConfig : IMacroConfig
{
// sources of unsafe ports:
// * chrome: https://chromium.googlesource.com/chromium/src.git/+/refs/heads/master/net/base/port_util.cc#27
// * firefox: https://www-archive.mozilla.org/projects/netlib/portbanning#portlist
// * safari: https://github.com/WebKit/WebKit/blob/42f5a93823a7f087a800cd65c6bc0551dbeb55d3/Source/WTF/wtf/URL.cpp#L969
private static readonly HashSet<int> UnsafePorts = new HashSet<int>()
{
2049, // nfs
3659, // apple-sasl / PasswordServer
4045, // lockd
6000, // X11
6665, // Alternate IRC [Apple addition]
6666, // Alternate IRC [Apple addition]
6667, // Standard IRC [Apple addition]
6668, // Alternate IRC [Apple addition]
6669, // Alternate IRC [Apple addition]
1719, // H323 (RAS)
1720, // H323 (Q931)
1723, // H323 (H245)
2049, // NFS
3659, // apple-sasl / PasswordServer [Apple addition]
4045, // lockd
5060, // SIP
5061, // SIPS
6000, // X11
6566, // SANE
6665, // Alternate IRC [Apple addition]
6666, // Alternate IRC [Apple addition]
6667, // Standard IRC [Apple addition]
6668, // Alternate IRC [Apple addition]
6669, // Alternate IRC [Apple addition]
6697, // IRC+SSL [Apple addition]
10080, // amanda
4190, // ManageSieve [Apple addition]
6679, // Alternate IRC SSL [Apple addition]
};

internal GeneratePortNumberConfig(string variableName, string? dataType, int fallback, int low, int high)
Expand Down