Additional VerificationEngine improvements/features #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlada-shubina
approved these changes
Oct 19, 2022
src/Microsoft.TemplateEngine.Authoring.CLI/Commands/Verify/VerifyCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.CLI/LocalizableStrings.resx
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
| /// <summary> | ||
| /// If set to true - the instantiation params are not appended to verification subdirectories. | ||
| /// </summary> | ||
| public bool? DoNotAppendParamsToScenarioName { get; init; } |
There was a problem hiding this comment.
Do we need a nullable here? Should it just default to false?
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
|
/backport to release/7.0.2xx |
|
Started backporting to release/7.0.2xx: https://github.com/dotnet/templating/actions/runs/3297652737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Several functional gaps and shortcommings were identified during integrating VerificationEngine into sdk integration tests
#3868
Solution
Added:
Checks:
#nullable enableto all the modified files ?