Implemented version without 'suppressHiddenDiagnostics' and returned …

…hard codings for CSxxxx fadings.
dotnet · Apr 10, 2019 · 7a24182 · 7a24182
1 parent c8e8dd2
commit 7a24182
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -590,11 +590,6 @@
           "default": false,
           "description": "Suppress the warning that project.json is no longer a supported project format for .NET Core applications"
         },
-        "csharp.suppressHiddenDiagnostics": {
-          "type": "boolean",
-          "default": true,
-          "description": "Suppress 'hidden' diagnostics (such as 'unnecessary using directives') from appearing in the editor or the Problems pane."
-        },
         "csharp.referencesCodeLens.enabled": {
           "type": "boolean",
           "default": true,

diff --git a/src/features/diagnosticsProvider.ts b/src/features/diagnosticsProvider.ts
@@ -325,7 +325,9 @@ class DiagnosticsProvider extends AbstractSupport {
     }
 
     private _asDiagnostic(quickFix: protocol.QuickFix): vscode.Diagnostic | undefined {
-        let isFadeout = (quickFix.Tags && !!quickFix.Tags.find(x => x.toLowerCase() == 'unnecessary'));
+        // CS0162 & CS8019 => Unnused using and unreachable code.
+        // These hard coded values bring some goodnes of fading even when analyzers are disabled.
+        let isFadeout = (quickFix.Tags && !!quickFix.Tags.find(x => x.toLowerCase() == 'unnecessary')) || quickFix.Id == "CS0162" || quickFix.Id == "CS8019";
 
         let severity = this._asDiagnosticSeverity(quickFix, isFadeout);