-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions in comments on trigger characters despite setting #1424
Comments
Yes. That is the design because trigger characters still have a purpose there, think of |
From @Dima4ka on April 21, 2017 21:48 @jrieken No, it was not snippet, it is rather "abc" guess (not intelligent). Looks like part of the HML comment
|
No 'ABC' icon for me, but the keyword icon. My guess is that this is coming from the C# extension. @DustinCampbell Ideas? |
From @DustinCampbell on April 24, 2017 13:22 Note that in C#, XML documentation comments aren't precisely "comments". They're very special. Also, in the example, the @jrieken, we're starting to get into territory that it is pretty tricky to get make correct for C# without a little help from VS Code's completion API to let us know how completion was triggered. C# completion can do different things depending on what the user did. Knowing whether the user triggered completion by typing the last character that appears in the document or whether they typing Ctrl+Space can be important. |
Yeah, this has come up before (microsoft/vscode#752) but hasn't been tackled yet. It's a little harder to do without breaking the API because we want to keep the rule "CancellationToken comes last"... I'll move the issue to vscode-omnisharp to begin with ;-) |
@DustinCampbell I spent some time with @akshita31 today getting familiar with this issue and the associated code paths. What were your thoughts for a fix? You mentioned above that this issue should live in omnisharp-vscode but I'm not convinced we have enough context until the request makes it to omnisharp-roslyn. The |
I honestly think this is probably just an issue in omnisharp-roslyn. It would likely just go away once we get the PRs in that just use Roslyn's completion API directly. |
I don't think it's an OmniSharp issue. I get it in Python as well. Even in this very thread, it was mentioned that it happens in TypeScript also. People end sentences with periods in comments. It's that simple. Even "special" comments like docstrings or anything else you care to think of. In any context where people are allowed to enter regular sentences in plain text, people are going to end those sentences with periods. I liked the suggestion to make the trigger characters different in different contexts. (Question: Is there a way to know what the trigger characters are, short of experimentation? I mean, other than periods, of course. Are they language-specific?) FWIW, the trigger-character suggestions do not show up for me in strings, no matter what I specify in Fortunately, we can get a little peace and quiet with |
This issue drives me insane on an hourly basis. 🤪 I've found dozens of issues that reference this problem, so it's not clear to me, is this issue (#1424) supposed to be the place to track this problem, or has it moved to another issue somewhere else? Trying to find out what the hold up is in fixing this. Can't figure out how this isn't driving enough people crazy to move it to a higher priority... is my configuration bad, or is no one else using punctuation in their code comments? 😂 |
@winzig - The hold-up might be that the issue isn't really related to OmniSharp, but rather VS Code itself. It used to drive me crazy (editing Python code; I've never installed OmniSharp) but I wound up just turning off all trigger character suggestions (see my previous comment). |
@jkyeung Thanks, I did notice your comment after I posted (of course). It definitely helps with the primary issue I'm facing, but now it highlights another problem – my memory of the c# language is apparently worse than I expected. ;-) In other words, I apparently rely on hitting "." to see what methods are available for a given type quite often. Hopefully this issue can be resolved somewhere soon. 🤣 |
The vscode team doesn't believe it's their fault - so where does the problem lie? This drives me crazy every day. I'm glad I'm not alone :) Does someone know which workaround has less side-effects for now:
or
|
Based on the discussion above, it sounds like this extension doesn't receive enough contextual information from omnisharp-roslyn to fix the problem. |
This issue also drives me nuts. |
Is this on the roadmap? It's insane...I love VS Code but I can't write comments without stumbling all over myself trying to avoid intellisense when I type a period at the end of my carefully crafted sentences :) |
Hmm. I don't have OmniSharp installed and got a similar issue with a different extension: SamVerschueren/vscode-ava#9 That one might be more distilled example. It seems more likely to me that it is actually a vscode bug after all. |
From @Dima4ka on April 21, 2017 1:44
Steps to Reproduce:
Expected
Nothing shows up
Actual
Silly suggestion (
!--
) shows upCopied from original issue: microsoft/vscode#25109
The text was updated successfully, but these errors were encountered: