Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow terminal configuration on Linux (currently hard-coded to gnome-terminal). #3

Closed
jrieken opened this issue Jan 20, 2016 · 4 comments
Closed

Allow terminal configuration on Linux (currently hard-coded to gnome-terminal). #3

jrieken opened this issue Jan 20, 2016 · 4 comments
Labels
Feature Request Resolved-External

Comments

@jrieken
Copy link
Contributor

jrieken commented Jan 20, 2016

From @Xorcist77 on December 17, 2015 15:10

I don't use gnome, and thus don't use gnome-terminal, but VSCode REALLY wants me to. I scaffolded out a new asp.net web project and can run it just fine from my terminal using 'dnx web', but trying to use 'dnx: web' from the command palette inside VSCode tries to launch gnome-terminal, which obviously fails, with the following error:

Error: spawn /usr/bin/gnome-terminal ENOENT

Note that I located workbench.main.js which appears to be the file that is referenced to open the terminal, however changing "usr/bin/gnome-terminal" to "usr/bin/x-terminal-emulator" didn't help. I didn't get any errors, but no terminal opened either... I would have expected it to use whatever terminal I configured in Linux at that point, instead of the hard coded gnome terminal.

I also tried "usr/bin/lxterminal" but that didn't work either...

Copied from original issue: microsoft/vscode#1421
@jrieken jrieken self-assigned this Jan 20, 2016
@jrieken
Copy link
Contributor Author

jrieken commented Jan 20, 2016

From @mosamy on January 5, 2016 21:5

I solved this by a simple sudo apt-get install gnome-terminal. It is only 11 mb and the seamless experience is worth it

@jrieken
Copy link
Contributor Author

jrieken commented Jan 20, 2016

From @Xorcist77 on January 6, 2016 0:10

@mosamy: That is more of a work around for the poorly designed, hard-coded, implementation currently provided by VSCode.

A configurable option would be much more appropriate. The fact something like this was hard-coded at all makes me wonder what other hidden gems l'm bound to uncover.

@jrieken
Copy link
Contributor Author

jrieken commented Jan 20, 2016

From @PeterBocan on January 16, 2016 13:8

It's that hard adding one key into the config? 👎 Okay.

@jrieken jrieken mentioned this issue Jan 20, 2016
Closed
@jrieken jrieken removed their assignment Jan 20, 2016
DustinCampbell added a commit that referenced this issue Feb 18, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
fc908a1 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit that referenced this issue Feb 18, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
c3f9680 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit that referenced this issue Feb 26, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
8bc3115 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit that referenced this issue Feb 26, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
796fe87 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit that referenced this issue Mar 1, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
2cb99ae 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit to DustinCampbell/vscode-csharp that referenced this issue Mar 2, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
f9fccd4 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, dotnet#2 and dotnet#3 would be ignored even if the value of #1 was invalid. Likewise, if dotnet#2 was set, dotnet#3 would be ignored even if the value of dotnet#2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit to DustinCampbell/vscode-csharp that referenced this issue Mar 4, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
cbd3780 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, dotnet#2 and dotnet#3 would be ignored even if the value of #1 was invalid. Likewise, if dotnet#2 was set, dotnet#3 would be ignored even if the value of dotnet#2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell added a commit that referenced this issue Mar 4, 2016
@DustinCampbell
Make OmniSharp launch settings more robust
8cfdabf 
The extension looks in three locations for OmniSharp:

1. Whatever the user specified in the "csharp.omnisharp" setting.
2. The value of the "OMNISHARP" environment variable.
3. The expected location where the bundled OmniSharp is copied.

If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
@DustinCampbell
Copy link
Member

This seems more like a VS Code issue that a C# extension issue.

@GraceDong GraceDong mentioned this issue Apr 24, 2017
Open
@qian6 qian6 mentioned this issue Jul 3, 2017
Closed
TheRealPiotrP referenced this issue in TheRealPiotrP/omnisharp-vscode Mar 6, 2018
@akshita31
Merge pull request #3 from TheRealPiotrP/refactorLogging
988fa76 
wallaby + a test
Samirat added a commit to github/omnisharp-vscode that referenced this issue May 21, 2020
@Samirat
Merge pull request dotnet#3 from Samirat/samirat/fix_omnisharp_locati…
fc929d8 
…on_problems

Fix omnisharp location problems, add mono installation warning
@Mailaender Mailaender mentioned this issue Mar 26, 2021
Closed
@rledyard rledyard mentioned this issue Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Resolved-External
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DustinCampbell @jrieken