Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting improvements for properties, events, interpolated strings, variables, fields #1026

Merged
merged 9 commits into from
Dec 14, 2016
Merged

Syntax highlighting improvements for properties, events, interpolated strings, variables, fields #1026

merged 9 commits into from
Dec 14, 2016

Conversation

ivanz
Copy link
Contributor

@ivanz ivanz commented Dec 11, 2016 •
edited
Loading

  • Adds highlighting for interpolated strings (verbatim and non-verbatim). Fixes c# 6.0 String interpolation not recognized by omnisharp #852
  • Adds highlighting for multi-line properties + tests. Fixes Inconsistent highlighting #854
  • Adds highlighting for events + tests
  • Adds highlighting for nested type references (e.g. Root.IInterface<Something.Nested>) + tests
  • Some other small fixes for variable declarations, nested classes, fields spanning multiple lines

Before:

image

image

After

image

image

@ivanz ivanz force-pushed the ivan-ivan-more-syntax-improvements branch from 3c5beb7 to 869aa26 Compare December 11, 2016 22:30
@ivanz ivanz changed the title Syntax highlighting of properties and events + fixes to variables and nested classes Syntax highlighting improvements of of properties. events, interpolated strings, variables Dec 11, 2016
@ivanz ivanz changed the title Syntax highlighting improvements of of properties. events, interpolated strings, variables Syntax highlighting improvements of properties, events, interpolated strings, variables, fields Dec 11, 2016
@ivanz ivanz changed the title Syntax highlighting improvements of properties, events, interpolated strings, variables, fields Syntax highlighting improvements for properties, events, interpolated strings, variables, fields Dec 11, 2016
DustinCampbell
DustinCampbell approved these changes Dec 14, 2016
View reviewed changes
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very, very nice!

@DustinCampbell DustinCampbell merged commit 12e0f04 into dotnet:master Dec 14, 2016
@ivanz ivanz deleted the ivan-ivan-more-syntax-improvements branch December 17, 2016 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent highlighting c# 6.0 String interpolation not recognized by omnisharp
3 participants
@ivanz @DustinCampbell @dnfclas