Fixed disabling of code lens references #1782
Conversation
package.json
Outdated
| "csharp.showTestsCodeLens": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Specifies whether the run and debug test CodeLens show be shown." |
There was a problem hiding this comment.
Typo: "should be should". It looks like the same typo appears above.
|
@rchande: Does this look good to you? |
src/features/codeLensProvider.ts
Outdated
|
|
||
| constructor(server: OmniSharpServer, reporter: TelemetryReporter, testManager: TestManager) | ||
| { | ||
| super(server, reporter); | ||
|
|
||
| this._testManager = testManager; | ||
| this._options = Options.Read(); |
There was a problem hiding this comment.
With this change, do we still turn codelens on/off as you switch between the prefernces tab and file?
There was a problem hiding this comment.
I don't think so. I would expect that this will require a restart of the extension to take effect.
There was a problem hiding this comment.
yeah indeed. Though I think this is consistent with the rest of the extension at the moment - we don't read any options in "real time" I think
There was a problem hiding this comment.
I think we're just inconsistent. For example, setting csharp.suppressDotnetRestoreNotification will take effect immediately. So will csharp.disableCodeActions. Maybe it's worth adding the extra logic to listen for vscode.workspace.onDidChangeConfiguration? Check out what we do in CodeActionProvider here
There was a problem hiding this comment.
thanks for the tip - I did not see that before. I pushed the appropriate change. Indeed, the experience is much nicer now 👍
| this.addDisposables(configChangedDisposable); | ||
| } | ||
|
|
||
| private _checkOptions(): void { |
There was a problem hiding this comment.
Nit--this method doesn't actually check anything. Maybe call it "_updatedCachedOptions" or something?
There was a problem hiding this comment.
Let's go back and fix that up with codeActionProvider at the same time, so that we're consistent. I'll send a follow up PR with that change.
|
thanks guys! 👍 |
This is a follow up to #1781.
The setting to disable references code lens inadvertently also disabled the run/debug test code lens.
This PR fixes that - so setting
csharp.showReferencesCodeLensdoesn't affect the test code lens.It also introduces a sibling setting -
csharp.showTestsCodeLens, which controls toggling the test code lens, without affecting the references code lens.