Enable noImplicitAny and alwaysStrict in `tsconfig.json

gulpfile.ts

@@ -10,6 +10,8 @@ import * as optionsSchemaGenerator from './src/tools/GenerateOptionsSchema';
 import * as packageDependencyUpdater from './src/tools/UpdatePackageDependencies';
 
 import tslint from 'gulp-tslint';
+import { PlatformInformation } from './src/platform';
+import { PackageManager } from './src/packages';
 
 require('./tasks/testTasks');
 require('./tasks/onlinePackagingTasks');
@@ -39,13 +41,4 @@ gulp.task('tslint', () => {
             summarizeFailureOutput: false,
             emitError: false
         }));
-});
-
-const lintReporter = (output, file, options) => {
-    //emits: src/helloWorld.c:5:3: warning: implicit declaration of function ‘prinft’
-    let relativeBase = file.base.substring(file.cwd.length + 1).replace('\\', '/');
-    output.forEach(e => {
-        let message = relativeBase + e.name + ':' + (e.startPosition.line + 1) + ':' + (e.startPosition.character + 1) + ': ' + e.failure;
-        console.log('[tslint] ' + message);
-    });
-};
+});

package.json

@@ -85,7 +85,11 @@
     "@types/chai-arrays": "1.0.2",
     "@types/chai-as-promised": "^7.1.0",
     "@types/chai-string": "^1.4.0",
+    "@types/del": "^3.0.1",
     "@types/fs-extra": "^5.0.1",
+    "@types/gulp": "^3.8.36",
+    "@types/gulp-mocha": "0.0.32",
+    "@types/istanbul": "^0.4.30",
     "@types/minimist": "^1.2.0",
     "@types/mkdirp": "^0.5.2",
     "@types/mocha": "^2.2.48",

src/assets.ts

@@ -60,7 +60,7 @@ export class AssetGenerator {
         this.initializeProjectData(workspaceInfo);
     }
 
-    private initializeProjectData(workspaceInfo: protocol.WorkspaceInformationResponse) {
+    private initializeProjectData(workspaceInfo: protocol.WorkspaceInformationResponse): void {
         // TODO: For now, assume the Debug configuration. Eventually, we'll need to revisit
         // this when we allow selecting configurations.
         const configurationName = 'Debug';
@@ -105,7 +105,7 @@ export class AssetGenerator {
             }
         }
 
-        return undefined;
+        return;
     }
 
     public hasWebServerDependency(): boolean {

src/coreclr-debug/activate.ts

@@ -2,7 +2,6 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-'use strict';
 
 import * as path from 'path';
 import * as vscode from 'vscode';

src/coreclr-debug/debuggerEventsProtocol.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 // This contains the definition of messages that VsDbg-UI can send back to a listener which registers itself via the 'debuggerEventsPipeName'
 // property on a launch or attach request.
 // 

src/coreclr-debug/util.ts

@@ -2,7 +2,6 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-'use strict';
 
 import * as path from 'path';
 import * as fs from 'fs';

src/features/abstractProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import { Disposable } from 'vscode';
 import { OmniSharpServer } from '../omnisharp/server';
 

src/features/changeForwarding.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import {Disposable, Uri, workspace} from 'vscode';
 import {OmniSharpServer} from '../omnisharp/server';
 import * as serverUtils from '../omnisharp/utils';
@@ -32,7 +30,7 @@ function forwardDocumentChanges(server: OmniSharpServer): Disposable {
 
 function forwardFileChanges(server: OmniSharpServer): Disposable {
 
-    function onFileSystemEvent(changeType: FileChangeType): (Uri) => void {
+    function onFileSystemEvent(changeType: FileChangeType): (uri: Uri) => void {
         return function(uri: Uri) 
         {
             if (!server.isRunning()) {

src/features/codeActionProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import * as vscode from 'vscode';
 import { OmniSharpServer } from '../omnisharp/server';
 import AbstractProvider from './abstractProvider';

src/features/codeLensProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import * as protocol from '../omnisharp/protocol';
 import * as serverUtils from '../omnisharp/utils';
 import * as vscode from 'vscode';

src/features/commands.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import { OmniSharpServer } from '../omnisharp/server';
 import * as serverUtils from '../omnisharp/utils';
 import { findLaunchTargets } from '../omnisharp/launcher';

src/features/completionItemProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import {extractSummaryText} from './documentation';
 import AbstractSupport from './abstractProvider';
 import * as protocol from '../omnisharp/protocol';

src/features/definitionProvider.ts

@@ -3,19 +3,18 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import * as serverUtils from '../omnisharp/utils';
 import {CancellationToken, DefinitionProvider, Location, Position, TextDocument, Uri} from 'vscode';
 import {GoToDefinitionRequest, MetadataRequest, MetadataSource} from '../omnisharp/protocol';
 import {createRequest, toLocation, toLocationFromUri} from '../omnisharp/typeConvertion';
 import AbstractSupport from './abstractProvider';
 import DefinitionMetadataDocumentProvider from './definitionMetadataDocumentProvider';
+import { OmniSharpServer } from '../omnisharp/server';
 
 export default class CSharpDefinitionProvider extends AbstractSupport implements DefinitionProvider {
     private _definitionMetadataDocumentProvider: DefinitionMetadataDocumentProvider;
 
-    constructor(server, definitionMetadataDocumentProvider: DefinitionMetadataDocumentProvider) {
+    constructor(server: OmniSharpServer, definitionMetadataDocumentProvider: DefinitionMetadataDocumentProvider) {
         super(server);
 
         this._definitionMetadataDocumentProvider = definitionMetadataDocumentProvider;

src/features/diagnosticsProvider.ts

@@ -59,11 +59,11 @@ export class Advisor {
 
     private _removeProjectFileCount(info: protocol.ProjectInformationResponse): void {
         if (info.DotNetProject && info.DotNetProject.SourceFiles) {
-            delete this._updateProjectFileCount[info.DotNetProject.Path];
+            delete this._projectSourceFileCounts[info.DotNetProject.Path];
         }
 
         if (info.MsBuildProject && info.MsBuildProject.SourceFiles) {
-            delete this._updateProjectFileCount[info.MsBuildProject.Path];
+            delete this._projectSourceFileCounts[info.MsBuildProject.Path];
         }
     }
 
@@ -162,17 +162,17 @@ class DiagnosticsProvider extends AbstractSupport {
     }
 
     private _onDocumentRemove(document: vscode.TextDocument) {
-        let key = document.uri.toString();
+        let key = document.uri;
         let didChange = false;
-        if (this._diagnostics[key]) {
+        if (this._diagnostics.get(key)) {
             didChange = true;
-            this._diagnostics[key].dispose();
-            delete this._diagnostics[key];
+            this._diagnostics.delete(key);
         }
-        if (this._documentValidations[key]) {
+
+        if (this._documentValidations[key.toString()]) {
             didChange = true;
-            this._documentValidations[key].cancel();
-            delete this._documentValidations[key];
+            this._documentValidations[key.toString()].cancel();
+            delete this._documentValidations[key.toString()];
         }
         if (didChange) {
             this._validateProject();

src/features/documentHighlightProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import AbstractSupport from './abstractProvider';
 import * as protocol from '../omnisharp/protocol';
 import * as serverUtils from '../omnisharp/utils';

src/features/documentSymbolProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import AbstractSupport from './abstractProvider';
 import * as serverUtils from '../omnisharp/utils';
 import {toDocumentSymbol} from '../omnisharp/typeConvertion';

src/features/documentation.ts

@@ -3,7 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
 import * as protocol from '../omnisharp/protocol';
 
 const summaryStartTag = /<summary>/i;

src/features/formattingEditProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import AbstractSupport from './abstractProvider';
 import * as protocol from '../omnisharp/protocol';
 import * as serverUtils from '../omnisharp/utils';

src/features/hoverProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import AbstractSupport from './abstractProvider';
 import * as protocol from '../omnisharp/protocol';
 import * as serverUtils from '../omnisharp/utils';

src/features/implementationProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import AbstractSupport from './abstractProvider';
 import { FindImplementationsRequest } from '../omnisharp/protocol';
 import * as serverUtils from '../omnisharp/utils';

src/features/json/jsonContributions.ts

@@ -2,7 +2,6 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-'use strict';
 
 import { Location, getLocation, createScanner, SyntaxKind } from 'jsonc-parser';
 import { ProjectJSONContribution } from './projectJSONContribution';
@@ -96,7 +95,7 @@ export class JSONCompletionItemProvider implements CompletionItemProvider {
 
     public provideCompletionItems(document: TextDocument, position: Position, token: CancellationToken): Thenable<CompletionList> {
         let currentWord = this.getCurrentWord(document, position);
-        let overwriteRange = null;
+        let overwriteRange: Range = null;
         let items: CompletionItem[] = [];
         let isIncomplete = false;
 

src/features/json/projectJSONContribution.ts

@@ -2,7 +2,6 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-'use strict';
 
 import * as nls from 'vscode-nls';
 

src/features/referenceProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import AbstractSupport from './abstractProvider';
 import * as protocol from '../omnisharp/protocol';
 import * as serverUtils from '../omnisharp/utils';

src/features/renameProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import AbstractSupport from './abstractProvider';
 import * as protocol from '../omnisharp/protocol';
 import * as serverUtils from '../omnisharp/utils';