Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another example to exception condition documentation #4505

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

gregg-miskelly
Copy link
Contributor

This adds another example to the exception condition documentation to hopefully clarify a question that @vchirikov raised.

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #4505 (e2a0368) into master (b2c8deb) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4505      +/-   ##
==========================================
- Coverage   69.08%   68.92%   -0.17%     
==========================================
  Files         109      109              
  Lines        4325     4325              
  Branches      756      756              
==========================================
- Hits         2988     2981       -7     
- Misses       1140     1148       +8     
+ Partials      197      196       -1     
Flag Coverage Δ
integration 52.21% <ø> (-0.20%) ⬇️
unit 84.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/omnisharp/fileOperationsResponseEditBuilder.ts 61.53% <0.00%> (-23.08%) ⬇️
src/features/semanticTokensProvider.ts 82.00% <0.00%> (-4.00%) ⬇️
src/features/codeLensProvider.ts 53.24% <0.00%> (-1.30%) ⬇️
src/features/diagnosticsProvider.ts 83.33% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d178594...e2a0368. Read the comment docs.

@gregg-miskelly gregg-miskelly merged commit 0d501a4 into master Apr 19, 2021
@gregg-miskelly gregg-miskelly deleted the gregg-miskelly/AddDocNote branch April 19, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants