Improve generation of tasks.json and launch.json assets #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows tasks.json and launch.json to be generated when the workspace root contains a global.json rather than a launch.json. It ensures that appropriate values to the json files to account for the target project being more deeply nested.
|
|
||
| function hasWebServerDependency(targetProjectData: TargetProjectData) { | ||
| if (!targetProjectData || !targetProjectData.projectJsonPath) { | ||
| return; |
There was a problem hiding this comment.
should this be 'return false'? Or does the caller handle undefined?
There was a problem hiding this comment.
Good catch. Yes, it should return false.
|
Otherwise LGTM |
DustinCampbell
force-pushed
the
fix-global-json
branch
from
09609e1
to
32d1172
Compare
It is no longer necessary to ensure that the workspace root contains a project.json (or global.json) before offering to generate tasks.json and launch.json. When launched, OmniSharp should scan for projects and, if any or found, we'll offer to generate the assets if needed.
|
Look better now @gregg-miskelly? |
|
@DustinCampbell LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #556 and #170
This change allows tasks.json and launch.json to be generated when the workspace root contains a global.json rather than a launch.json. It ensures that appropriate values to the json files to account for the target project being more deeply nested.
cc @gregg-miskelly, @rajkumar42, @caslan, @chuckries