Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client side support for refreshing source generated files #7791

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

dibarbet
Copy link
Member

Implements client side support for refreshing source generated files. Requires server side change to be merged and inserted in this PR.

sg_refresh

@dibarbet dibarbet requested a review from a team as a code owner November 15, 2024 21:16
dibarbet added a commit to dotnet/roslyn that referenced this pull request Nov 16, 2024
Client side PR - dotnet/vscode-csharp#7791

Implements support for refreshing source generated files provided by
LSP. Refresh notifications are sent to the client based on workspace
changes that may affect source generated files. To handle the
overreporting of refresh notifications, I also implemented resultId
based support in the get text handler - it will now avoid re-sending the
entire text to the client if nothing has changed.


![sg_refresh](https://github.com/user-attachments/assets/065a8532-56c7-4e45-a559-0a451d37697a)
@dibarbet dibarbet merged commit a92d5b3 into dotnet:main Nov 20, 2024
16 checks passed
@dibarbet dibarbet deleted the refresh_sg branch November 20, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants