This repository has been archived by the owner on May 21, 2024. It is now read-only.
Sniff for dotnet-sdk and don't do what OmniSharp already does #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
reviewed
Jun 14, 2021
| @@ -58,12 +63,6 @@ async function initializeDependencies() { | |||
|
|
|||
| // Acquire .NET Interactive | |||
| initializeDependency("ms-dotnettools.dotnet-interactive-vscode", "dotnet-interactive.acquire", sdkResult?.dotnetPath); | |||
|
|
|||
| // Start OmniSharp | |||
| initializeDependency("ms-dotnettools.csharp", "o.restart"); | |||
There was a problem hiding this comment.
It would be useful to activate the C# extension to kick off dependency acquisition. However, there is no need to execute either of the commands.
There was a problem hiding this comment.
Yeah, I'm thinking we should just not do that for now.
There was a problem hiding this comment.
Okay, confirmed that this works without issue. I will merge this and publish an update, since functionally this doesn't really change things other than no longer causing this conflict.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something in the latest VSCode creates problems when we try to call this command unconditionally.
Also, we should not be restarting the O# server according to @JoeRobich