Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _RunWithCoreWcfService a variable again #5655

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

mconnew
Copy link
Member

@mconnew mconnew commented Sep 30, 2024

Due to Azure DevOps not trusting my GitHub account to make changes to the yml for the corewcf ci run, the PR triggered build will fail due to not being able to use the access token. I've kicked off a manual build for the same commit which can use the access token (because Azure DevOps trusts my Azure authenticated account). You can verify this is doing the right thing by seeing that the step "Update
_updateService variable" is skipped. This is the step which populates the service url and sets a variable telling a later step to update the test servers to be in line with the PR. We still have tests failing due to still ramping up CoreWCF for tests, so looking at this step is the easiest way to check if the _RunWithCoreWcfService variable is working as expected.
https://dev.azure.com/dnceng-public/public/_build/results?buildId=822804&view=results

@mconnew mconnew force-pushed the TestingPipelineChanges branch 9 times, most recently from 04428fb to 4eb7da9 Compare September 30, 2024 21:19
@mconnew mconnew changed the title Make _RunWithCoreWcfService parameter default true for corewcf build definitions Make _RunWithCoreWcfService a variable again Sep 30, 2024
@mconnew
Copy link
Member Author

mconnew commented Sep 30, 2024

I pushed one more update since the manual pipeline run, but the only change was to update the commit comment as I originally tried to make the parameter default dynamic, but that didn't work. Instead I got it working with a variable. The changes in the commit are identical.

@HongGit HongGit mentioned this pull request Oct 1, 2024
@HongGit HongGit merged commit ea7d491 into dotnet:main Oct 1, 2024
8 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants