Respond to feedback. Remove nullable disable.

dotnet · Nov 3, 2021 · ae58704 · ae58704
1 parent 73bfe7e
commit ae58704
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/System.Windows.Forms/src/System/Windows/Forms/PropertyGrid.TabInfo.cs b/src/System.Windows.Forms/src/System/Windows/Forms/PropertyGrid.TabInfo.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#nullable disable
-
 using System.ComponentModel;
 using System.Windows.Forms.Design;
 

diff --git a/src/System.Windows.Forms/src/System/Windows/Forms/PropertyGrid.cs b/src/System.Windows.Forms/src/System/Windows/Forms/PropertyGrid.cs
@@ -1653,8 +1653,9 @@ private PropertyTab CreateTab(Type tabType, IDesignerHost host)
             {
                 tab = CreatePropertyTab(tabType);
             }
-            catch (Exception)
+            catch (Exception exception)
             {
+                Debug.Fail($"{nameof(CreatePropertyTab)} failed. {exception.Message}");
                 return null;
             }
 
@@ -1689,14 +1690,13 @@ private PropertyTab CreateTab(Type tabType, IDesignerHost host)
                         tab = (PropertyTab)Activator.CreateInstance(tabType);
                     }
                 }
-                catch
+                catch (Exception exception)
                 {
+                    Debug.Fail($"Failed to create {nameof(PropertyTab)}. {exception.Message}");
                     tab = null;
                 }
             }
 
-            Debug.Assert(tab is not null, "Failed to create tab!");
-
             if (tab is not null)
             {
                 if (tab.Bitmap is null)