Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test DataGridView_RowHeadersWidth_SetWithHandle_GetReturnsExpected #6739

Closed
runfoapp bot opened this issue Feb 22, 2022 · 2 comments · Fixed by #8574
Closed

Flaky test DataGridView_RowHeadersWidth_SetWithHandle_GetReturnsExpected #6739

runfoapp bot opened this issue Feb 22, 2022 · 2 comments · Fixed by #8574
Assignees
Labels
test-bug Problem in test source code (most likely)

Comments

@runfoapp
Copy link

runfoapp bot commented Feb 22, 2022

Runfo Tracking Issue: setwithhandle_getreturnsexpected flaky failure in rolling

Build Definition Kind Run Name
134217 dotnet-winforms CI PR 8492 Windows_x64-xunit
134217 dotnet-winforms CI PR 8492 Windows_x64-xunit
134217 dotnet-winforms CI PR 8492 Windows_x64-xunit
134217 dotnet-winforms CI PR 8492 Windows_x64-xunit
134217 dotnet-winforms CI PR 8492 Windows_x64-xunit
134217 dotnet-winforms CI PR 8492 Windows_x64-xunit
134217 dotnet-winforms CI PR 8492 Windows_x64-xunit
134217 dotnet-winforms CI PR 8492 Windows_x64-xunit
134217 dotnet-winforms CI PR 8492 Windows_x64-xunit

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 1
@RussKie RussKie added the test-bug Problem in test source code (most likely) label Feb 23, 2022
@RussKie RussKie changed the title setwithhandle_getreturnsexpected flaky failure in rolling Flaky test DataGridView_RowHeadersWidth_SetWithHandle_GetReturnsExpected Mar 29, 2022
@kirsan31
Copy link
Contributor

kirsan31 commented Apr 8, 2022

@RussKie I've offered a couple of ideas here:

I think it wood be helpful (to investigate further) to know inputs (parameters) and CallStack of extra Invalidated. So, for example this test:

control.Invalidated += (sender, e) => invalidatedCallCount++;

can be transform to something like:

control.Invalidated += (sender, e) =>
{
    Assert.True(++invalidatedCallCount <= expectedInvalidatedCallCount,
        $"Input: {rowHeadersWidthSizeMode}, {rowHeadersVisible}, {autoSize}, {value}");
};

What do you think?

dmitrii-drobotov pushed a commit to dmitrii-drobotov/winforms that referenced this issue Apr 8, 2022
These tests sometimes fail in CI and block deployment.
Related issues: dotnet#6610, dotnet#6714, dotnet#6739, dotnet#6926
dmitrii-drobotov pushed a commit to dmitrii-drobotov/winforms that referenced this issue Apr 8, 2022
These tests sometimes fail in CI and block deployment.
Related issues: dotnet#6610, dotnet#6714, dotnet#6739, dotnet#6926
dmitrii-drobotov pushed a commit to dmitrii-drobotov/winforms that referenced this issue Apr 8, 2022
These tests sometimes fail in CI and block deployment.
Related issues: dotnet#6610, dotnet#6714, dotnet#6739, dotnet#6926
dreddy-work pushed a commit that referenced this issue Apr 8, 2022
These tests sometimes fail in CI and block deployment.
Related issues: #6610, #6714, #6739, #6926
@Tanya-Solyanik
Copy link
Member

@Olina-Zhang - plese comment out the line of theory data that causes failures

@ghost ghost added the 🚧 work in progress Work that is current in progress label Feb 8, 2023
@dkazennov dkazennov self-assigned this Feb 8, 2023
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Feb 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants