Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ITextRangeProvider/ITextProvider to Cswin32 #10022

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Convert ITextRangeProvider/ITextProvider to Cswin32 #10022

merged 6 commits into from
Oct 3, 2023

Conversation

lonitra
Copy link
Member

@lonitra lonitra commented Sep 29, 2023 •
edited
Loading

Related: #9795

  • Move references of ITextProvider, ITextProvider2, ITextRangeProvider to Cswin32
  • Add Improvements to SafeArrayScope to be able to receive SAFEARRAY* (similar to ComScope pattern)
  • Add ComSafeArrayScope for better usability when we need a SAFEARRAY that contains COM interfaces (SafeArrayScope<nint>)
  • Add explicit operators for converting to/from VARIANT and double
  • Add implicit operator to convert to/from UiaPoint and Point
  • Update tests
Microsoft Reviewers: Open in CodeFlow

@lonitra lonitra requested a review from a team as a code owner September 29, 2023 22:36
@ghost ghost assigned lonitra Sep 29, 2023
@lonitra
Add IManagedWrapper and fix release build
1719e1c
@lonitra
Address feedback + other simplification
e174713
@lonitra
- Rename TryGetManagedInterface -> TryGetObjectForIUnknown
dca7c19 
- Remove UiaTextProvider2
- Add safety checks for SafeArrayScope
- Add new private constructor for UiaTextRange
- Seal internal classes that are not derived from
- Add tests
JeremyKuhne
JeremyKuhne reviewed Oct 3, 2023
View reviewed changes
src/System.Windows.Forms.Primitives/src/Windows/Win32/ComHelpers.cs Outdated
}
}

@interface = default;
return false;
}

#pragma warning disable CS1574 // XML comment has cref attribute 'TryGetObjectForIUnknown{TObject}(IUnknown*, bool, out TObject?)' that could not be resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Intellisense work for the method or not? If it doesn't then we should figure out how to fix this or manually add the comments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intellisense can find the method, but for some reason it is not resolving the cref. I can look into more how this can be resolved or just add the comments manually if nothing else.

JeremyKuhne
JeremyKuhne approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@lonitra lonitra merged commit 46c647f into dotnet:main Oct 3, 2023
9 checks passed
@lonitra lonitra deleted the accessibleobj branch October 3, 2023 15:54
@ghost ghost locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeremyKuhne JeremyKuhne JeremyKuhne approved these changes

Assignees

@lonitra lonitra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonitra @JeremyKuhne