Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start migrating UiaCore to CsWin32 #10200

Merged
merged 11 commits into from
Nov 1, 2023
Merged

Start migrating UiaCore to CsWin32 #10200

merged 11 commits into from
Nov 1, 2023

Conversation

elachlan
Copy link
Contributor

@elachlan elachlan commented Oct 27, 2023

Related: #7445, #9795

This is just a start, focusing on the enums. I mostly used find/replace and corrected any compile errors.

Microsoft Reviewers: Open in CodeFlow

@elachlan elachlan requested a review from a team as a code owner October 27, 2023 03:28
@ghost ghost assigned elachlan Oct 27, 2023
@elachlan
Copy link
Contributor Author

It looks like @lonitra has already started this at #10177

@elachlan elachlan closed this Oct 27, 2023
@elachlan
Copy link
Contributor Author

I might be wrong actually.

@elachlan elachlan reopened this Oct 27, 2023
@lonitra
Copy link
Member

lonitra commented Nov 1, 2023

Changes LGTM, thanks for doing this! 🥳 The PR mentioned above only converts enums that are related to IRawElementProviderSimple, so definitely not the amount of enum conversion this PR covers. Did you have the chance to test changes by going through WinformsControlsTest with Narrator?

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Nov 1, 2023
@elachlan
Copy link
Contributor Author

elachlan commented Nov 1, 2023

It's all the enums. I didn't run through the narrator tests.

@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 1, 2023
@lonitra
Copy link
Member

lonitra commented Nov 1, 2023

We recently ran into an issue while converting UIA enums that metadata had defined their enums incorrectly. In that case metadata had defined enum as uint instead of int which caused Narrator to announce things incorrectly as it was expecting int. I think we are ok here, but it is good to make sure. I will pull down changes and test with Narrator some time today.

@elachlan
Copy link
Contributor Author

elachlan commented Nov 1, 2023

I generally check ilspy to confirm all values are in the enums.

I'll make a note to check the data type as well.

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested. Narrator seems to be announcing things correctly 🚀

@lonitra lonitra merged commit 12ff6d3 into dotnet:main Nov 1, 2023
9 checks passed
@ghost ghost added this to the 9.0 Preview1 milestone Nov 1, 2023
@elachlan elachlan deleted the CsWin32-UIA branch November 1, 2023 23:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants