Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert IRawElementProviderFragment to Cswin32 #10288

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

lonitra
Copy link
Member

@lonitra lonitra commented Nov 13, 2023

Related: #9795

  • Remove our definition of IRawElementProviderFragment, which deals with navigating, focus, and bounding rects in favor of cswin32 definition
  • Also removed our definition of UiaRect
  • Update tests (2nd commit)

*Did manual testing and sent to CTI for testing

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned lonitra Nov 13, 2023
@ghost ghost added the draft draft PR label Nov 14, 2023
@lonitra lonitra marked this pull request as ready for review November 15, 2023 00:49
@lonitra lonitra requested a review from a team as a code owner November 15, 2023 00:49
@lonitra lonitra removed the draft draft PR label Nov 15, 2023
JeremyKuhne
JeremyKuhne previously approved these changes Nov 15, 2023
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit. Looks good!

JeremyKuhne
JeremyKuhne previously approved these changes Nov 15, 2023
@lonitra lonitra merged commit dd02ac8 into dotnet:main Nov 15, 2023
8 of 9 checks passed
@ghost ghost added this to the 9.0 Preview1 milestone Nov 15, 2023
@lonitra lonitra deleted the providerfragment branch November 16, 2023 23:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants