Mark Test Utilities As Packable Nonshipping #12407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Windows.Forms.TestUtilities
…ndows.Core.TestUtilities
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ControlTests.Handlers.cs
Outdated
Show resolved
Hide resolved
| @@ -1,9 +1,10 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <AssemblyName>System.Windows.Forms.Common.TestUtilities</AssemblyName> | |||
| <AssemblyName>System.Private.Windows.Core.TestUtilities</AssemblyName> | |||
There was a problem hiding this comment.
Are you going to rename the folder in a separate PR to preserve history?
There was a problem hiding this comment.
Right now this assembly lives under the test folder. I was not planning to rename it as I think it should still be there.
There was a problem hiding this comment.
I meant the common folder
There was a problem hiding this comment.
Ah I see. I think the folder name is still applicable, but I'm open to renaming.
JeremyKuhne
reviewed
Oct 31, 2024
lonitra
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12407 +/- ##
====================================================
+ Coverage 49.20480% 75.63612% +26.43132%
====================================================
Files 1985 3147 +1162
Lines 283954 635806 +351852
Branches 41730 47012 +5282
====================================================
+ Hits 139719 480899 +341180
- Misses 141535 151458 +9923
- Partials 2700 3449 +749
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
approved these changes
Oct 31, 2024
JeremyKuhne
approved these changes
Nov 1, 2024
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark some of our test utilities in a project that is packable nonshipping in preparation to share this with WPF. In this PR I've:
Next step here is to investigate if it is possible to have documentation for classes/methods in our shared assembly show up in intellisense within WPF repo but keep it out of windowsdesktop. Currently developers need to navigate via F12 to see any documentation for System.Private.Windows.Core.
Microsoft Reviewers: Open in CodeFlow