Merge pull request #2707 from RussKie/Unblock_flow_to_WindowsDesktop #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables dotnet/windowsdesktop#365 To reduce the x-repo overhead of managing Windows Forms assemblies ship the list of assemblies in our transport package. This will allow for a simpler ingestion by WindowsDesktop repo, yet retains ability to break ingestion, if the list of assemblies is outdated.
RussKie
force-pushed
the
Unblock_flow_to_WindowsDesktop
branch
from
346c2fd to
4114851
Compare
Revert versions to f3ac126 level, where MicrosoftNETCoreApppackageVersion=5.0.0-alpha1.19514.1 until dotnet/wpf#2399 (comment) is resolved. This version is very likely compatible with the WPF repo right now.
RussKie
force-pushed
the
Unblock_flow_to_WindowsDesktop
branch
from
4114851 to
f8a529e
Compare
RussKie
changed the title
ghost
added this to the 
|
@vatsan-madhavan this should get us moving |
|
/cc @rladuca |
|
I’ve closed dotnet/wpf#2399. Let’s kick a new darc pr (or let maestro do it in its own course overnight) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Ship WinForms references in transport package
Enables Import WinForms references from transport package windowsdesktop#365
To reduce the x-repo overhead of managing Windows Forms assemblies ship the list of assemblies in our transport package.
This will allow for a simpler ingestion by WindowsDesktop repo, yet retains ability to break ingestion if the list of assemblies is outdated.
Revert to Revert versions to f3ac1266 level, where MicrosoftNETCoreApppackageVersion=5.0.0-alpha1.19514.1 #2497 (revert to versions to f3ac126 level)
Revert versions to f3ac126 level, where
MicrosoftNETCoreApppackageVersion=5.0.0-alpha1.19514.1until [master] Update dependencies from dotnet/winforms wpf#2399 (comment) is resolved.This version is very likely compatible with the WPF repo right now.
Enables [master] Update dependencies from dotnet/winforms wpf#2399
Microsoft Reviewers: Open in CodeFlow