Fix issue with showing groups in the Inspector when groups are disabled #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4677 +/- ##
===================================================
- Coverage 97.97893% 97.95490% -0.02404%
===================================================
Files 547 547
Lines 265652 266002 +350
Branches 5103 5106 +3
===================================================
+ Hits 260283 260562 +279
- Misses 4486 4547 +61
- Partials 883 893 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
requested changes
Mar 15, 2021
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListViewItem.cs
Outdated
Show resolved
Hide resolved
...rms/tests/UnitTests/System/Windows/Forms/ListViewGroup.ListViewGroupAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
📭 waiting-author-feedback
SergeySmirnov-Akvelon
force-pushed
the
Issue-4205_ListViewGroup_AccessibleObject_behavior
branch
from
c8d4e59
to
23ed35e
Compare
ghost
removed
the
📭 waiting-author-feedback
SergeySmirnov-Akvelon
force-pushed
the
Issue-4205_ListViewGroup_AccessibleObject_behavior
branch
from
23ed35e
to
53e5bfb
Compare
RussKie
previously approved these changes
Mar 16, 2021
RussKie
added
the
📬 waiting-for-testing
SergeySmirnov-Akvelon
force-pushed
the
Issue-4205_ListViewGroup_AccessibleObject_behavior
branch
2 times, most recently
from
76e2987
to
9fc1881
Compare
RussKie
previously approved these changes
Mar 22, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
SergeySmirnov-Akvelon
force-pushed
the
Issue-4205_ListViewGroup_AccessibleObject_behavior
branch
from
9fc1881
to
75188d9
Compare
…otnet#4205 Added conditions to ignore ListViewGroupAccessibleObjects when groups or visual styles are disabled Updated unit tests.
SergeySmirnov-Akvelon
force-pushed
the
Issue-4205_ListViewGroup_AccessibleObject_behavior
branch
from
75188d9
to
95babbc
Compare
RussKie
approved these changes
Mar 24, 2021
SergeySmirnov-Akvelon
added
waiting-review
|
Approved by CTI team |
RussKie
removed
the
waiting-review
wreuel
pushed a commit
to wreuel/winforms
that referenced
this pull request
Apr 13, 2021
…ed (dotnet#4677) Added conditions to ignore ListViewGroupAccessibleObjects when groups or visual styles are disabled Updated unit tests.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4205
Fixes #4678
Proposed changes
ListViewGroupAccessibleObjectwhen groups or visual styles are disabledCustomer Impact
Regression?
Risk
Test methodology
Accessibility testing
Microsoft Reviewers: Open in CodeFlow