Resume invocation of OnParentHandleRecreated for child control when form recreates handle #6113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc: @chenxinyanc |
dreddy-work
reviewed
Nov 3, 2021
…orm recreates handle Fixes dotnet#6093 Fix the regression introduced in dotnet#2262.
RussKie
force-pushed
the
fix_6093_children_controls_not_rendered_when_parent_recreated
branch
from
e8bda90 to
cca5560
Compare
RussKie
commented
Nov 4, 2021
| @@ -9827,6 +9827,9 @@ internal virtual void RecreateHandleCore() | |||
| // the call shouldn't fail. | |||
| // However, it could fail if this.CreateParams.Parent is changed outside our control. | |||
| CreateHandle(); | |||
|
|
|||
| // DestroyHandle resets the state, but CreateHandle doesn't set the state back. | |||
| SetState(States.Created, true); | |||
There was a problem hiding this comment.
This flag is set in CreateControl:
dreddy-work
approved these changes
Nov 4, 2021
dreddy-work
added
the
📬 waiting-for-testing
RussKie
deleted the
fix_6093_children_controls_not_rendered_when_parent_recreated
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6093, the regression introduced in #2262.
Proposed changes
Restore the required state after the handle was re-created.
#2262 has added a check to the method handling recreation of a control handle to verify that the control is created before any child controls can be re-parented on to it.
However it was missed that
DestroyHandle()method resets the state (i.e. removesCreatedstate), butCreateHandle()method doesn't set the state back.Customer Impact
ShowInTaskbarproperty) will be correctly rendered.Regression?
Risk
Screenshots
Before
On the left
ListBoxandCheckedListBoxcontrols, on the rightListViewcontrols.After
Test methodology
Microsoft Reviewers: Open in CodeFlow