Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade #6263

Merged
merged 3 commits into from
Dec 7, 2021
Merged

[main] Update dependencies from dotnet/arcade #6263

merged 3 commits into from
Dec 7, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 3, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: b9a1a4bb-2302-4987-3b3d-08d8b8050dda
  • Build: 20211203.6
  • Date Produced: December 4, 2021 4:37:31 AM UTC
  • Commit: b3e949192067c8acdaaae35015534f76e92d79d4
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20211…
7112ff9 
…202.3

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21602.3
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner December 3, 2021 13:08
ghost
ghost previously approved these changes Dec 3, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20211…
a380959 
…203.6

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21603.6
@bekir-ozturk
Copy link
Contributor

I'm checking this as it seems related to the recent localization related change here: dotnet/arcade#8233

@bekir-ozturk bekir-ozturk self-assigned this Dec 6, 2021
@bekir-ozturk bekir-ozturk mentioned this pull request Dec 6, 2021
Merged
1 task
@RussKie RussKie merged commit 9cc28d1 into main Dec 7, 2021
@RussKie RussKie deleted the darc-main-e2f13e41-4a04-4cf3-a273-fadaeb716e6a branch December 7, 2021 00:14
@bekir-ozturk
Copy link
Contributor

Thanks for getting this unblocked, @RussKie.
A proper fix has been deployed and will flow here soon which will update Microsoft.DotNet.Arcade.Sdk to 7.0.0-beta.21606.6.

Setting <EnableXlfLocalization>false</EnableXlfLocalization> shouldn't be necessary afterwards.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees

@bekir-ozturk bekir-ozturk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekir-ozturk @RussKie