Set Control.Defaultfont to SystemFonts.MessageBoxFont #656

wjk · 2019-03-30T22:21:23Z

This change ensures Segoe UI is used by default on Windows Vista and later, while still not breaking compatibility with Windows XP or systems compatible with it. Fixes #524.

Note that while I have not yet been able to test the code in System.Design.Editors as requested in #524 (comment) due to #632 not yet being merged, I have tested with the WinformsControlTest project, and all of its forms/controls (including the ThreadExceptionDialog) are sized properly to avoid clipping text, with no changes needed. While I do not think any changes will be needed to the designer code either, I am willing to hold on this PR until that can be tested. Thanks!

codecov · 2019-03-30T22:44:57Z

Codecov Report

Merging #656 into master will decrease coverage by 0.02931%.
The diff coverage is 100%.

@@                Coverage Diff                 @@
##              master       #656         +/-   ##
==================================================
- Coverage   34.00101%   33.9717%   -0.02931%     
==================================================
  Files           1103       1103                 
  Lines         320714     320714                 
  Branches       38944      38944                 
==================================================
- Hits          109046     108952         -94     
- Misses        207193     207295        +102     
+ Partials        4475       4467          -8

Flag	Coverage Δ
#Debug	`33.9717% <100%> (-0.02932%)`	⬇️
#production	`22.04788% <100%> (-0.03473%)`	⬇️
#test	`98.56731% <100%> (ø)`	⬆️

zsd4yr · 2019-04-01T17:37:22Z

Thanks @wjk

Due to the testing gap, let's hold our horses until #632 gets in

merriemcgaw · 2019-04-01T19:06:37Z

@dreddy-work can you review this and see if this approach will work for WinForms?

zsd4yr · 2019-04-15T17:30:58Z

@dreddy-work

dreddy-work · 2019-04-15T18:09:48Z

@wjk, In your testing, did you check caption and menbar fonts as well?

DefaultFont was using 'GetStockObject' with 'DEFAULT_GUI_FONT' and its been suggested to not use that as it may not work for all windows themes. This makes me think if we should make the change in 'DefaultFont' directly.

wjk · 2019-04-15T18:12:32Z

DefaultFont is part of System.Drawing, which is in corefx, not here. That's one reason why I made the change the way I did.

I have not tested caption and menubar fonts, but those should be Segoe UI already. I know that MenuStrips default to Segoe UI, even in a form that uses MS Sans Serif, because it sets its font to the menubar font.

dreddy-work · 2019-04-15T22:56:05Z

@wjk i have seen your comment on other issue. We can request a PR on corefx but please wait until we hear from Windows team on this. We will update this thread soon to close on this.

zsd4yr · 2019-05-10T20:44:24Z

@dreddy-work any word from Windows?

zsd4yr · 2019-05-15T19:54:29Z

pinging @dreddy-work

dreddy-work · 2019-05-15T20:02:15Z

We have not received any update from windows team on this. Change here is simple. Concern is, will there be any scenario where the text will be truncated on some controls because of Font/FontSize change? should this be controlled with opt-in or opt-out somehow? or, we should be okay to break those scenarios? I am in favor of taking this as is. @Tanya-Solyanik as FYI.

merriemcgaw · 2019-05-29T23:39:00Z

@wjk We think this looks good to go. Can you resolve conflicts so I can merge?

RussKie · 2019-05-30T03:38:37Z

Please squash and rebase on top of the latest master.
Thank you

wjk · 2019-05-30T19:10:02Z

@RussKie @merriemcgaw What should be done about that test failure? The issue is that the font set by default is now identical to the font being set in the test in at least one (but quite possibly all) of the test cases. I could change this test to use e.g. Consolas or hard-coded MS Sans Serif (or some other font installed as part of Windows) instead. Does that sound good?

RussKie · 2019-05-31T06:04:03Z

How about this?

diff --git a/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs b/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
index 74cea883..254dc4f1 100644
--- a/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
+++ b/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
@@ -377,3 +377,3 @@ namespace System.Windows.Forms.Tests
             // Set different.
-            Font font1 = SystemFonts.MenuFont;
+            Font font1 = new Font("Arial", 8.25f);
             control.Font = font1;

wjk · 2019-05-31T17:48:02Z

@RussKie I've pushed your suggested change to the PR branch. Unfortunately, when locally it doesn't seem to have any effect. I would appreciate some pointers. (I'll squash the branch again once the tests are passing.) Thanks!

RussKie · 2019-06-01T01:43:39Z

For your branch with the change I suggested all tests pass, if I run them locally from the cli (.\build -test) or run the tests in a vscode.
VS gives all sorts of red herrings, but not for the tests that fail on the build server.
If I rebase your changes on top of the latest master (65a813c) the tests are succeeding as well...

Looking at the build server results, the failure is caused by unrelated tests.
@AdamYoblick any thoughts?

RussKie · 2019-06-03T04:41:22Z

You have missed one more instance where the font needed changing.
Please squash-rebase and we'll get it merged.
Thanks

This change ensures Segoe UI is used by default on Windows Vista and later, while still not breaking compatibility with Windows XP or systems compatible with it.

AdamYoblick · 2019-06-03T16:04:25Z

Yep looks like the build passed. Must have been some flaky tests. As more tests get added, this seems to be happening more often. Probably a indication that some of our code is non-deterministic.

RussKie · 2019-06-03T22:30:55Z

Thank you

199621616 · 2019-12-16T06:50:37Z

我的迁移过程，遇到了这个痛苦的抉择。是迁移到.NetCore，还是停止迁移？
#2503
可以自定义默认字体嘛？

RussKie · 2019-12-16T21:12:23Z

@199621616 I have already asked you to write messages in English. Further non-English messages will be deleted.

Whenever ambient font changed, this change would stomp over user-defined DataGridView font styles, such as * DefaultCellStyle * ColumnHeadersDefaultCellStyle * RowHeadersDefaultCellStyle Whilst the behaviour goes all the way back to .NET Framework, it becomes a significant migration issue for projects that want to keep the original default font (that was changed in dotnet#656). Prevent changes to either of the above cellstyles, if those configured by a user. Resolves dotnet#3033

Whenever ambient font changed, this change would stomp over user-defined DataGridView font styles, such as * DefaultCellStyle * ColumnHeadersDefaultCellStyle * RowHeadersDefaultCellStyle Whilst the behaviour goes all the way back to .NET Framework, it becomes a significant migration issue for projects that want to keep the original default font (that was changed in #656). Prevent changes to either of the above cellstyles, if those configured by a user. Resolves #3033

The default font has been updated in .NET Core 3.0 (dotnet#656) and documented. However for some users who built their apps in pixel-perfect manner this change has proved to be a significant hurdle in migrating their apps to .NET. Allow setting application-wide default font in a similar manner we set high dpi or visual styles: Application.SetDefaultFont(new Font(new FontFamily("Calibri"), 11f)); * The application-wide default font can only be set before the first window is created by an application. * The font will be scaled by the system text scale factor, whenever it is getting changed. Resolves dotnet#3001

The default font has been updated in .NET Core 3.0 (#656) and documented. However for some users who built their apps in pixel-perfect manner this change has proved to be a significant hurdle in migrating their apps to .NET. Allow setting application-wide default font in a similar manner we set high dpi or visual styles: Application.SetDefaultFont(new Font(new FontFamily("Calibri"), 11f)); * The application-wide default font can only be set before the first window is created by an application. * The font will be scaled by the system text scale factor, whenever it is getting changed. Resolves #3001

wjk requested a review from a team as a code owner March 30, 2019 22:21

zsd4yr requested a review from dreddy-work April 15, 2019 17:31

wjk force-pushed the SegoeUI branch 3 times, most recently from 4afaef7 to 7abeb7f Compare May 30, 2019 18:18

RussKie mentioned this pull request Jun 1, 2019

Add TreeView property tests #1080

Merged

RussKie closed this Jun 3, 2019

RussKie reopened this Jun 3, 2019

Set Control.DefaultFont to SystemFonts.MessageBoxFont

524df06

This change ensures Segoe UI is used by default on Windows Vista and later, while still not breaking compatibility with Windows XP or systems compatible with it.

wjk force-pushed the SegoeUI branch from ccb25e3 to 524df06 Compare June 3, 2019 13:18

RussKie merged commit 0508793 into dotnet:master Jun 3, 2019

This was referenced Sep 9, 2019

UI Layout broken in later previews. #1827

Closed

Form.FormBorderStyle == SizeableToolWindow not working. #1338

Closed

RussKie mentioned this pull request Feb 1, 2020

The name 'fontFamily' and 'fontSize' do not exist in the current context dotnet/runtime#29732

Closed

RussKie mentioned this pull request Mar 21, 2020

Allow set font application-wide #3001

Closed

This was referenced Jul 16, 2020

dataGridView doesn't respect font settings if new form's Font != DefaultFont #3033

Closed

WIP: Convert to .NET Core 3.1 gitextensions/gitextensions#7162

Closed

RussKie mentioned this pull request Sep 10, 2020

Do not reset user fonts in DataGridView #3875

Merged

RussKie mentioned this pull request Oct 15, 2020

UI Larger in Framework 5 #4107

Closed

RussKie mentioned this pull request May 14, 2021

[Proposal] Streamline application configuration and bootstrap #4909

Closed

RussKie mentioned this pull request May 14, 2021

Allow set application-wide default font #4911

Merged

ghost locked as resolved and limited conversation to collaborators Feb 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set Control.Defaultfont to SystemFonts.MessageBoxFont #656

Set Control.Defaultfont to SystemFonts.MessageBoxFont #656

wjk commented Mar 30, 2019

codecov bot commented Mar 30, 2019 •

edited

Loading

zsd4yr commented Apr 1, 2019

merriemcgaw commented Apr 1, 2019

zsd4yr commented Apr 15, 2019

dreddy-work commented Apr 15, 2019

wjk commented Apr 15, 2019

dreddy-work commented Apr 15, 2019

zsd4yr commented May 10, 2019

zsd4yr commented May 15, 2019

dreddy-work commented May 15, 2019 •

edited

Loading

merriemcgaw commented May 29, 2019

RussKie commented May 30, 2019

wjk commented May 30, 2019

RussKie commented May 31, 2019

wjk commented May 31, 2019

RussKie commented Jun 1, 2019 •

edited

Loading

RussKie commented Jun 3, 2019

AdamYoblick commented Jun 3, 2019

RussKie commented Jun 3, 2019

199621616 commented Dec 16, 2019

RussKie commented Dec 16, 2019

Set Control.Defaultfont to SystemFonts.MessageBoxFont #656

Set Control.Defaultfont to SystemFonts.MessageBoxFont #656

Conversation

wjk commented Mar 30, 2019

codecov bot commented Mar 30, 2019 • edited Loading

Codecov Report

zsd4yr commented Apr 1, 2019

merriemcgaw commented Apr 1, 2019

zsd4yr commented Apr 15, 2019

dreddy-work commented Apr 15, 2019

wjk commented Apr 15, 2019

dreddy-work commented Apr 15, 2019

zsd4yr commented May 10, 2019

zsd4yr commented May 15, 2019

dreddy-work commented May 15, 2019 • edited Loading

merriemcgaw commented May 29, 2019

RussKie commented May 30, 2019

wjk commented May 30, 2019

RussKie commented May 31, 2019

wjk commented May 31, 2019

RussKie commented Jun 1, 2019 • edited Loading

RussKie commented Jun 3, 2019

AdamYoblick commented Jun 3, 2019

RussKie commented Jun 3, 2019

199621616 commented Dec 16, 2019

RussKie commented Dec 16, 2019

codecov bot commented Mar 30, 2019 •

edited

Loading

dreddy-work commented May 15, 2019 •

edited

Loading

RussKie commented Jun 1, 2019 •

edited

Loading