Delay first execution of ICommand.CanExecute(object parameter) until … #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after initialization. Issue dotnet#316 Revert changes to Hyperlink.cs
ghost
requested review from
ghost
added
the
|
|
|
@MichaelVach, Thanks for the contribution here - we appreciate it! We are not accepting behavior changing PR's at this time with very rare exceptions (for e.g., something critical to the release of .NET Core 3.0) - so I'm closing this PR. Let's continue discussing #316 and agreeing on a fix approach that factors in app-compat concerns. Once you have a fix approach that is accepted by the product team and .NET 5 contributions have been opened up, we will be happy to reconsider PR's for this if it makes sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…after initialization. Issue #316
Revert changes to Hyperlink.cs