WPF TextBox insertion caret does not render when moved to lower DPI monitor in a PMAv2 process #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so we should not apply the ConvertPixel adjustment.
ghost
requested review from
vatsan-madhavan,
rladuca,
ryalanms and
stevenbrix
ghost
added
the
|
Hello @SamBent! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 30 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
vatsan-madhavan
approved these changes
Sep 24, 2019
rladuca
approved these changes
Sep 24, 2019
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TextBox insertion caret fails to render when on a lower DPI monitor than primary when per-monitor awareness is enabled.
Customer Impact
VS features that rely on Text Caret position (search controls, commit messages, Editor, etc) are unable to easily tell where their focus is when using these features if PMA support is enabled and the text box is rendered off the primary display.
Regression
No. (Port of .NET 4.8 servicing fix)
Risk
Low
Fixes #1774
WPF TextBox insertion caret does not render when moved to lower DPI monitor in a PMAv2 process.