Explicit delegate types #5954
Merged
Explicit delegate types #5954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to please AOT compilers. Removed not used MilGlyphCache_SetCreateGlyphBitmapsCallback Technically NativeAOT would handle that after dotnet/runtime#63219 but want to cleanup just in case overall I think using untyped delegates in C# is wrong
ghost
added
the
ghost
requested review from
|
@dipeshmsft can I ask, is this kind of changes are welcome here? I probably have bunch of similar one, in order to improve AOT scenarios for WPF |
|
Hey @kant2002 these kind of changes are welcome. But at of now, we are working on getting to a stable state after which we will start taking changes. |
|
Can I ask to add this to "Queue to test pass" ? |
|
Hey @kant2002 we are still looking at the changes. Once done, we will add the label for this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to please AOT compilers.
Removed not used MilGlyphCache_SetCreateGlyphBitmapsCallback
Technically NativeAOT would handle that after dotnet/runtime#63219 but want to cleanup just in case
overall I think using untyped delegates in C# is wrong
Fixes dotnet/runtimelab#1107