You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We really need to rethink the whole GenerateTemporaryTargetAssembly using a different solution like source generators. Instead of adding every single property over time. First was the project name, then file, then output paths and now namespace!
@Nirmal4G I agree with you that this build process is not optimal. This PR is more like a patch instead of fixing the problem at its root which is that the build process is weird. Unfortunately, this is the best I can do without changing a bunch of things since the build process requires BAML compilation which requires a built assembly so that it can output resources to add to said assembly. For now this requires 2 build but I have changes locally that instead of triggering a whole build it just adds the resources to the assembly in the first build using Cecil but it is not PR-ready.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Community ContributionA label for all community ContributionsPRmetadata: Label to tag PRs, to facilitate with triage
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
requested review from
ThomasGoulet73
force-pushed
the
fix-razor-source-generator-build
branch
from
ghost
locked as resolved and limited conversation to collaborators
Fixes #4421
Fixes #5697
Description
Fixes build when using Razor source generator by adding RootNamespace to the list of property added to the generated project.
Without this PR, the Razor source generator would generate files in the wrong namespace (
WpfBlazorRepro_5s0cnboz_wpftmpinstead ofWpfBlazorRepro).Fixes incremental build where the RootNamespace is changing on each build and therefore is recognized as a fresh build (Not incremental).
Customer Impact
Without this PR, customers cannot build a WPF application with the Razor source generator (Maybe others?).
Regression
No. To my knowledge, it never worked.
Testing
Tested by building the repro project in the issue (https://github.com/Eilon/WPFXamlRazorGeneratorBug). This PR fixed the build.
Tested the repro here: #5697 (comment). This PR makes the repro build incrementally.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow