WASM: Add pumping of timer queue to ThreadlessXunitTestRunner #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premun
approved these changes
Aug 3, 2020
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 3, 2020
We only pumped the threadpool but we didn't pump the timer queue inside the xharness runner, so in the case of Task.Delay() it'll schedule a callback on the timer queue and that will never happen which leads to the infinite loop waiting for the test to finish. To fix that we call an internal method to pump the timer queue like we do for the threadpool. Requires an xharness bump to include dotnet/xharness#290 Fixes dotnet#38931
akoeplinger
added a commit
to dotnet/runtime
that referenced
this pull request
Aug 4, 2020
* WASM: Pump timer queue in xharness when running unit tests We only pumped the threadpool but we didn't pump the timer queue inside the xharness runner, so in the case of Task.Delay() it'll schedule a callback on the timer queue and that will never happen which leads to the infinite loop waiting for the test to finish. To fix that we call an internal method to pump the timer queue like we do for the threadpool. Requires an xharness bump to include dotnet/xharness#290 Fixes #38931 * Don't nullref if no timers were started
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
) * WASM: Pump timer queue in xharness when running unit tests We only pumped the threadpool but we didn't pump the timer queue inside the xharness runner, so in the case of Task.Delay() it'll schedule a callback on the timer queue and that will never happen which leads to the infinite loop waiting for the test to finish. To fix that we call an internal method to pump the timer queue like we do for the threadpool. Requires an xharness bump to include dotnet/xharness#290 Fixes dotnet#38931 * Don't nullref if no timers were started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for dotnet/runtime#38931
/cc @premun @mandel-macaque