fix wait group usage

douban · Oct 17, 2023 · 12eca64 · 12eca64
1 parent a146f55
commit 12eca64
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/exporter/exporter.go b/exporter/exporter.go
@@ -125,9 +125,8 @@ func (e *CdnExporter) Collect(ch chan<- prometheus.Metric) {
 				"Error collecting cdn metrics", nil, nil),
 			errors.New("empty domain list"))
 	}
+	var wg sync.WaitGroup
 	for _, domain := range *e.domainList {
-
-		var wg sync.WaitGroup
 		domain := domain
 		wg.Add(1)
 		go func() {
@@ -362,6 +361,6 @@ func (e *CdnExporter) Collect(ch chan<- prometheus.Metric) {
 				)
 			}
 		}()
-		wg.Wait()
 	}
+	wg.Wait()
 }