Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] KEYCODE_MEDIA_NEXT does not trigger with Capability.NEXT not set as notification capability on Android #2180

Closed
lovegaoshi opened this issue Oct 21, 2023 · 4 comments

Comments

@lovegaoshi
Copy link
Contributor

Describe the Bug
The bug is described here: podverse/podverse-rn#1758
for ios, RNTP behaves as normal. for android Event.RemoteSkipNext will simply not fire (via bluetooth, as notification button is hidden) when Capability.next is not set as a notification capability, because MediaSessionConnector.QueueNavigator does not enable the next/previous actions then. This is fine for most apps but not for podverse, where the next/previous buttons should be replaced by forward/backward buttons.

Steps To Reproduce
Take out Capability.Next in notifications and try next/previous with a bluetooth headset on android

Code To Reproduce
like lovegaoshi/KotlinAudio@43a23de#diff-aac2898870a901482661b6a0bfd73dbbab38fc17fc1f8591a6fce7ab31f9c76a

Replicable on Example App?
yes.

Environment Info:
not relevant

How I can Help
I override onMediaButtonEvent for mediaSessionCompat.Callback (I think I wrote this part for the android auto PR?) to specifically handle skip next and previous events for podverse. unsure what the best practice is though.
lovegaoshi/KotlinAudio@43a23de#diff-9c7fc38508b88eca04e110589f9f3c473b526e10a0451c87796dc53f9a9f20f8

@lovegaoshi lovegaoshi added the Bug label Oct 21, 2023
@dcvz
Copy link
Contributor

dcvz commented Oct 21, 2023

Right, at the moment the capabilities are both used to determine what the notification shows /and/ media session actions. I have a PR in the works that reworks and separates those two: #2076

@lovegaoshi
Copy link
Contributor Author

lovegaoshi commented Oct 21, 2023 via email

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 20, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants