New/feedback enhancement #450
Open
+523
−709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stage will be used to sequence a number of feedback rounds when reviewing a particular student submission. This commit adds the ability to post and get stages. Co-authored-by: ugonj <ugonj@users.noreply.github.com> Co-authored-by: wakedreamer <wakedreamer@users.noreply.github.com>
Added feedback folder loading into application. No module needed in the model. Using a module for the feedback api folder. Co-authored-by: ugonj <ugonj@users.noreply.github.com> Co-authored-by: wakedreamer <wakedreamer@users.noreply.github.com> Co-authored-by: ublefo <ublefo@users.noreply.github.com>
changed task comment fail to needs improvement added migration fix
…d/doubtfire-api into maddernd-fix/fail_comments_change
…change fix: change_task_comment_fail
…ncement Merge latest changes from dev branch into backend Tutor feedback branch
The code changes add the Stage model to the Feedback API, allowing for the creation and updating of stages.
The code changes add a new table called "stages" to the schema.rb file. This table includes columns for "title", "order", and "task_definition_id".
The code changes include the addition of tests for the FeedbackGroup model and updated tests for the FeedbackCommentTemplate model. These tests ensure that a valid feedback group can be created and that invalid feedback groups are handled correctly.
The code changes include the addition of factories and tests for the FeedbackGroup and FeedbackCommentTemplate models. These factories allow for the creation of valid feedback groups and comment templates, and the tests ensure that the models are functioning correctly.
The code changes include the addition of the FeedbackGroup and FeedbackCommentTemplate models, along with their corresponding tests. These models allow for the creation of valid feedback groups and comment templates, and the tests ensure their proper functionality.
This commit updates the feedback feature api endpoints for compatibity with revised models and database schema.
- Modified `feedback_comment_template.rb`, `feedback_group.rb`, and `task_definition.rb` models to align with the new feedback structure. - Removed outdated migrations related to stages and criterion options and introduced new migrations for Feedback Groups and Feedback Comment Templates. - Updated schema to reflect the new feedback group/template structure. - Refactored factories for `FeedbackCommentTemplate` and `FeedbackGroup` to align with the new model relationships. - Deleted obsolete tests and introduced new tests for `FeedbackCommentTemplate` and `FeedbackGroup` to ensure correct functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request overhauls the existing feedback API, replacing Stages with Feedback Comment templates and adding feedback groups.
includes significant changes to the API structure, particularly focusing on feedback-related entities and endpoints. The changes involve the removal of certain APIs and entities, updates to existing ones, and modifications to the installation script for additional packages.
API Structure Changes:
app/api/api_root.rb: ReplacedFeedbackApi::StageApiwithFeedbackApi::FeedbackGroupApiand removedFeedbackApi::CriterionApiandFeedbackApi::CriterionOptionApimounts. Updated authentication helpers accordingly.app/api/entities/feedback_entities/criterion_entity.rb: Removed theCriterionEntityclass.app/api/entities/feedback_entities/criterion_option_entity.rb: Removed theCriterionOptionEntityclass.app/api/entities/feedback_entities/feedback_comment_entity.rb: Removed theFeedbackCommentEntityclass.app/api/entities/feedback_entities/feedback_comment_template_entity.rb: Added a newFeedbackCommentTemplateEntityclass.Endpoint Changes:
app/api/feedback_api/criterion_api.rb: Removed the entireCriterionApiclass and its associated endpoints.app/api/feedback_api/criterion_option_api.rb: Removed the entireCriterionOptionApiclass and its associated endpoints.app/api/feedback_api/feedback_comment_template_api.rb: Updated theFeedbackCommentTemplateApiclass to use new parameters and logic for handling feedback comment templates.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
If you have any questions, please contact @macite or @jakerenzella.